Fix iOS Frida bug for devices with - in UDID

I had assumed that wasn't valid, and I'm definitely wrong, so we need to
catch that case. We now use a much less likely separator, and join again
anyway just in case it comes up somehow.

Author: pimterry

src/interceptors/frida/frida-ios-integration.ts

@@ -59,6 +59,8 @@ export async function getIosFridaHosts(usbmuxClient: UsbmuxClient): Promise<Reco
     ));
 }
 
+const HOST_ID_SEPARATOR = '---';
+
 const getHostDetails = async (usbmuxClient: UsbmuxClient, deviceId: number) => {
     const deviceMetadataPromise = usbmuxClient.queryAllDeviceValues(deviceId);
 
@@ -81,17 +83,17 @@ const getHostDetails = async (usbmuxClient: UsbmuxClient, deviceId: number) => {
         'Unknown iOS Device';
 
     return {
-        id: `${deviceId}-${deviceMetadata.UniqueDeviceID}`, // Host id = both (to avoid deviceid change races)
+        id: `${deviceId}${HOST_ID_SEPARATOR}${deviceMetadata.UniqueDeviceID}`, // Host id = both (to avoid deviceid change races)
         name: deviceName,
         type: 'ios',
         state
     } as const;
 };
 
 async function getDeviceId(usbmuxClient: UsbmuxClient, hostId: string) {
-    const parts = hostId.split('-');
+    const parts = hostId.split(HOST_ID_SEPARATOR);
     const deviceId = parseInt(parts[0]);
-    const udid = parts[1];
+    const udid = parts.slice(1).join(HOST_ID_SEPARATOR);
 
     const realUdid = await usbmuxClient.queryDeviceValue(deviceId, 'UniqueDeviceID');