Hide Chrome warning fixes from the intercepted requests

pimterry · pimterry · commit 3877cd3bae8c · 2018-11-28T19:07:01.000+01:00
diff --git a/src/hide-chrome-warning-server.ts b/src/hide-chrome-warning-server.ts
@@ -49,6 +49,11 @@ export class HideChromeWarningServer {
         `);
     }
 
+    get host(): string {
+        return this.server!.url
+            .replace('https://', '');
+    }
+
     get hideWarningUrl(): string {
         return this.server.url.replace(/\/?$/, '/hide-chrome-warning');
     }
diff --git a/src/interceptors/fresh-chrome.ts b/src/interceptors/fresh-chrome.ts
@@ -46,6 +46,8 @@ export class FreshChrome {
         const browser = await launchBrowser(hideWarningServer.hideWarningUrl, {
             browser: 'chrome',
             proxy: `https://localhost:${proxyPort}`,
+            // Don't intercept our warning hiding requests
+            noProxy: hideWarningServer.host,
             options: [
                 `--ignore-certificate-errors-spki-list=${spkiFingerprint}`
             ]

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,11 @@ export class HideChromeWarningServer {`
`49`	`49`	`);
`50`	`50`	`}`
`51`	`51`
	`52`	`+ get host(): string {`
	`53`	`+ return this.server!.url`
	`54`	`+ .replace('https://', '');`
	`55`	`+ }`
	`56`	`+`
`52`	`57`	`get hideWarningUrl(): string {`
`53`	`58`	`return this.server.url.replace(/\/?$/, '/hide-chrome-warning');`
`54`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,8 @@ export class FreshChrome {`
`46`	`46`	`const browser = await launchBrowser(hideWarningServer.hideWarningUrl, {`
`47`	`47`	`browser: 'chrome',`
`48`	`48`	proxy: `https://localhost:${proxyPort}`,
	`49`	`+ // Don't intercept our warning hiding requests`
	`50`	`+ noProxy: hideWarningServer.host,`
`49`	`51`	`options: [`
`50`	`52`	`--ignore-certificate-errors-spki-list=${spkiFingerprint}`
`51`	`53`	`]`