Skip to content

Commit 4782a12

Browse files
committed
Stop the chrome warning server traffic being intercepted
It's not a big problem if it is, but it results in a less nice error if chrome setup fails, and it's extra & meaningless noise.
1 parent d8b9379 commit 4782a12

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/interceptors/fresh-chrome.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,12 @@ export class FreshChrome implements Interceptor {
5454
browser: (await getChromeBrowserName(this.config)) || 'chrome',
5555
proxy: `https://127.0.0.1:${proxyPort}`,
5656
noProxy: [
57-
// Don't intercept our warning hiding requests
58-
hideWarningServer.host,
5957
// Force even localhost requests to go through the proxy
6058
// See https://bugs.chromium.org/p/chromium/issues/detail?id=899126#c17
61-
'<-loopback>'
59+
'<-loopback>',
60+
// Don't intercept our warning hiding requests. Note that this must be
61+
// the 2nd rule here, or <-loopback> would override it.
62+
hideWarningServer.host
6263
],
6364
options: [
6465
// Trust our CA certificate's fingerprint:

0 commit comments

Comments
 (0)