Skip to content

Commit 754e65d

Browse files
committed
Ignore Buffer() deprecation warning
This is caused by the ftp module, used in the pac-proxy-agent module, because PAC URLs may be FTP. That proxy agent is in turn used inside Mockttp for proxy support. This only appears in built packages annoyingly, because it only fires for non-node_modules deprecations. The issue itself isn't actually a security issue, it's here: https://github.com/mscdex/node-ftp/blob/7dff82fc049a52f51803bdffb95ec1de383f9fac/lib/connection.js#L53
1 parent 57f4075 commit 754e65d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/integration-test.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ describe('Integration test', function () {
7878
if (d.toString().includes('ExperimentalWarning: The fs.promises API')) return;
7979
// We use _stream_wrap, in some node versions this is deprecated, for now ignore it
8080
if (d.toString().includes('The _stream_wrap module is deprecated')) return;
81+
// Deprecation in 'ftp' module (from pac-proxy) - only appears in built package, not source,
82+
// as node doesn't show these deprecations by default when fired within node_modules.
83+
if (d.toString().includes('Buffer() is deprecated') && process.env.TEST_BUILT_TARBALL) return;
8184
// If the config parent folder doesn't exist at all, we'll see an ENOENT, that's ok:
8285
if (d.toString().includes('[ENOENT]')) return;
8386

0 commit comments

Comments
 (0)