Ensure metadata failures don't fail the entire interceptor check

Author: pimterry

src/api-server.ts

@@ -131,10 +131,15 @@ const buildResolvers = (
                     return false;
                 }
             },
-            metadata: (interceptor: Interceptor) => {
-                return interceptor.getMetadata
-                    ? interceptor.getMetadata()
-                    : undefined;
+            metadata: async (interceptor: Interceptor) => {
+                try {
+                    return interceptor.getMetadata
+                        ? await interceptor.getMetadata()
+                        : undefined;
+                } catch (e) {
+                    reportError(e);
+                    return undefined;
+                }
             }
         },
 

src/interceptors/android/android-adb-interceptor.ts

@@ -64,7 +64,7 @@ export class AndroidAdbInterceptor implements Interceptor {
         return false;
     }
 
-    async getMetadata() {
+    async getMetadata(): Promise<{ deviceIds: string[] }> {
         return {
             deviceIds: await getConnectedDevices(this.adbClient)
         };