Skip to content

Commit 89ab9f1

Browse files
committed
Fix iconv webpack warning
1 parent b1359a1 commit 89ab9f1

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

package-lock.json

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
"needle": "^2.4.0",
7171
"node-dev": "^3.1.3",
7272
"node-fetch": "^2.6.0",
73+
"node-noop": "^1.0.0",
7374
"request": "^2.88.0",
7475
"request-promise-native": "^1.0.5",
7576
"reqwest": "^2.0.5",

webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ module.exports = {
4040
],
4141
plugins: [
4242
// Optimistic require for 'iconv' in 'encoding', falls back to 'iconv-lite'
43-
new webpack.IgnorePlugin(/^iconv$/),
43+
new webpack.NormalModuleReplacementPlugin(/\/iconv-loader$/, 'node-noop'),
4444
// Optimistically required in (various) ws versions, with fallback
4545
new webpack.IgnorePlugin(/^bufferutil$/),
4646
// Optimistically required in (various) ws versions, with fallback

0 commit comments

Comments
 (0)