Skip to content

Commit 9fffdc7

Browse files
committed
Actually ensure Chrome proxies localhost requests (oops)
1 parent f5b71bf commit 9fffdc7

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/interceptors/fresh-chrome.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,16 @@ export class FreshChrome implements Interceptor {
5353
// and might find a new install.
5454
browser: (await getChromeBrowserName(this.config)) || 'chrome',
5555
proxy: `https://localhost:${proxyPort}`,
56-
// Don't intercept our warning hiding requests
57-
noProxy: hideWarningServer.host,
58-
options: [
59-
// Trust our CA certificate's fingerprint:
60-
`--ignore-certificate-errors-spki-list=${spkiFingerprint}`,
56+
noProxy: [
57+
// Don't intercept our warning hiding requests
58+
hideWarningServer.host,
6159
// Force even localhost requests to go through the proxy
6260
// See https://bugs.chromium.org/p/chromium/issues/detail?id=899126#c17
63-
`--proxy-bypass-list='<-loopback>'`
61+
'<-loopback>'
62+
],
63+
options: [
64+
// Trust our CA certificate's fingerprint:
65+
`--ignore-certificate-errors-spki-list=${spkiFingerprint}`
6466
]
6567
}, this.config.configPath);
6668

0 commit comments

Comments
 (0)