Make deactivate reliable on OSX by using stop() instead of process.kill()

Author: pimterry

custom-typings/@james-proxy/index.d.ts

@@ -48,6 +48,8 @@ declare module '@james-proxy/james-browser-launcher' {
             process: ChildProcess;
             stderr: stream.Readable;
             stdout: stream.Readable;
+
+            stop(): void;
         }
     }
 

src/interceptors/fresh-chrome.ts

@@ -66,8 +66,9 @@ export class FreshChrome {
     async deactivate(proxyPort: number) {
         if (this.isActive(proxyPort)) {
             const browser = browsers[proxyPort];
-            browser!.process.kill();
-            await new Promise((resolve) => browser!.process.once('exit', resolve));
+            const exitPromise = new Promise((resolve) => browser!.process.once('exit', resolve));
+            browser!.stop();
+            await exitPromise;
         }
     }
 };

src/interceptors/fresh-firefox.ts

@@ -100,8 +100,9 @@ export class FreshFirefox {
     async deactivate(proxyPort: number) {
         if (this.isActive(proxyPort)) {
             const browser = browsers[proxyPort];
-            browser!.process.kill();
-            await new Promise((resolve) => browser!.process.once('exit', resolve));
+            const exitPromise = new Promise((resolve) => browser!.process.once('exit', resolve));
+            browser!.stop();
+            await exitPromise;
         }
     }
 };