Add a test for the client, and fix the URL bugs it found

Previously we passed host instead of hostname (so it broke on
non-default ports) and lost the query string entirely.

Author: pimterry

src/client/client.ts

@@ -28,12 +28,7 @@ export async function sendRequest(
 ): Promise<ResponseDefinition> {
     const url = new URL(requestDefn.url);
 
-    const request = (url.protocol === 'https:' ? https : http).request({
-        protocol: url.protocol,
-        host: url.host,
-        port: url.port,
-        path: url.pathname,
-
+    const request = (url.protocol === 'https' ? https : http).request(requestDefn.url, {
         method: requestDefn.method,
 
         // Node supports sending raw headers via [key, value, key, value] array, but we need an

test/client/send-request.spec.ts

@@ -0,0 +1,48 @@
+import { expect } from 'chai';
+import * as mockttp from 'mockttp';
+
+import { sendRequest } from '../../src/client/client';
+
+describe("The HTTP client API", () => {
+
+    const mockServer = mockttp.getLocal({ debug: true });
+
+    beforeEach(() => mockServer.start());
+    afterEach(() => mockServer.stop());
+
+    it("should send requests", async () => {
+        await mockServer.forAnyRequest().thenCallback(async (request) => {
+            expect(request.url).to.equal(`http://localhost:${mockServer.port}/path?qwe=asd`);
+            expect(request.method).to.equal('POST');
+            expect(
+                request.rawHeaders.find(([key]) => key === 'CUSTOM-header')
+            ).to.deep.equal(['CUSTOM-header', 'CUSTOM-value']);
+            expect(await request.body.getText()).to.equal('Request body')
+
+            return {
+                statusCode: 200,
+                statusMessage: 'Custom status message',
+                headers: { 'custom-HEADER': 'custom-VALUE' },
+                rawBody: Buffer.from('Mock response body')
+            };
+        });
+
+        const response = await sendRequest({
+            url: mockServer.urlFor('/path?qwe=asd'),
+            method: 'POST',
+            headers: [
+                ['host', `localhost:${mockServer.port}`],
+                ['content-length', '12'],
+                ['CUSTOM-header', 'CUSTOM-value']
+            ],
+            rawBody: Buffer.from('Request body')
+        }, {});
+
+        expect(response.statusCode).to.equal(200);
+        expect(response.statusMessage).to.equal('Custom status message');
+        expect(response.headers).to.deep.equal([
+            ['custom-HEADER', 'custom-VALUE']
+        ]);
+        expect(response.rawBody!.toString()).to.equal('Mock response body');
+    })
+});