Handle races in Docker container removal/recreation

Author: pimterry

src/interceptors/docker/docker-commands.ts

@@ -2,6 +2,8 @@ import * as _ from 'lodash';
 import * as Docker from 'dockerode';
 import * as path from 'path';
 
+import { delay } from '../../util/promise';
+
 import { getTerminalEnvVars } from '../terminal/terminal-env-overrides';
 import { transformComposeCreationLabels } from './docker-compose';
 import { getDockerDataVolumeName } from './docker-data-injection';
@@ -214,6 +216,11 @@ export async function restartAndInjectContainer(
         }
     });
 
+    // There can be a delay here - wait until the container disappears
+    while (await container.inspect().catch(() => false)) {
+        await delay(100);
+    }
+
     // First we clone the continer, injecting our custom settings:
     const newContainer = await docker.createContainer(
         await transformContainerCreationConfig(