Commit d4e402c
committed
Fix python interception for http.client requests with inline ports
Previously, calling http.client.HTTPConnection('example.com', 80)
worked fine, but http.client.HTTPConnection('example.com:80') failed
because that string was used directly as the host, with the default
80 set as the port separately in our override. The override now
delegates handling this back to Python itself, to ensure that works
correctly.
Most users aren't doing this directly anyway, and libraries typically
call low-level HTTP methods with the full port automatically, but
it can fail in some real-world cases.1 parent 3f45ee4 commit d4e402c
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
0 commit comments