Disable existing terminal for Windows for now

pimterry · pimterry · commit d4f8a7506d9e · 2019-11-15T16:39:30.000+01:00
diff --git a/src/interceptors/terminal/existing-terminal-interceptor.ts b/src/interceptors/terminal/existing-terminal-interceptor.ts
@@ -23,7 +23,9 @@ export class ExistingTerminalInterceptor implements Interceptor {
     constructor(private config: HtkConfig) { }
 
     isActivable(): Promise<boolean> {
-        return Promise.resolve(true);
+        // Not supported on Windows, for now. Doesn't work in cmd or powershell of course (needs bash),
+        // and doesn't work in git bash/WSL due to path transforms. Fixable, I think, but not easily.
+        return Promise.resolve(process.platform !== 'win32');
     }
 
     isActive(proxyPort: number): boolean {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,9 @@ export class ExistingTerminalInterceptor implements Interceptor {`
`23`	`23`	`constructor(private config: HtkConfig) { }`
`24`	`24`
`25`	`25`	`isActivable(): Promise<boolean> {`
`26`		`- return Promise.resolve(true);`
	`26`	`+ // Not supported on Windows, for now. Doesn't work in cmd or powershell of course (needs bash),`
	`27`	`+ // and doesn't work in git bash/WSL due to path transforms. Fixable, I think, but not easily.`
	`28`	`+ return Promise.resolve(process.platform !== 'win32');`
`27`	`29`	`}`
`28`	`30`
`29`	`31`	`isActive(proxyPort: number): boolean {`