Skip to content

Commit ea982aa

Browse files
committed
Test distributables against multiple runner versions, not just latest
This caused the release issues with v1.12.4, because we only tested against Mac v12, and node-datachannel had issues on v11. We were testing v11 in the past, but macos-latest updated in October 2022. We include MacOS 10.15 here just for now, but note that it will start to hit brownouts in July 2023, and at that point we should drop it entirely. This also updates the OS versions used in build & publish CI steps too. Oddly it seems GHA hits an internal error before starting to build if the (pre-test) build step OS version isn't also updated? Very odd.
1 parent 21075bc commit ea982aa

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

.github/workflows/ci.yml

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ env:
55
jobs:
66
build:
77
name: Build & test
8-
runs-on: ubuntu-18.04
8+
runs-on: ubuntu-22.04
99
container:
1010
image: httptoolkit/act-build-base:v3.0.0
1111
options: "--privileged" # Required for DIND tests
@@ -84,14 +84,26 @@ jobs:
8484
strategy:
8585
matrix:
8686
include:
87-
- platform: Linux
88-
os: "ubuntu-latest"
87+
- platform: Ubuntu 22.04
88+
os: "ubuntu-22.04"
8989
test-script: "./unix.sh linux"
90-
- platform: Mac
91-
os: "macos-latest"
90+
- platform: Ubuntu 20.04
91+
os: "ubuntu-20.04"
92+
test-script: "./unix.sh linux"
93+
- platform: MacOS 12
94+
os: "macos-12"
95+
test-script: "./unix.sh darwin"
96+
- platform: MacOS 11
97+
os: "macos-11"
9298
test-script: "./unix.sh darwin"
93-
- platform: Windows
94-
os: "windows-latest"
99+
- platform: MacOS 10.15
100+
os: "macos-10.15" # Deprecated - nice-to-test now, but remove this entirely once GitHub stops supporting it
101+
test-script: "./unix.sh darwin"
102+
- platform: Windows 2022
103+
os: "windows-2022"
104+
test-script: ".\\windows.bat"
105+
- platform: Windows 2019
106+
os: "windows-2019"
95107
test-script: ".\\windows.bat"
96108
fail-fast: false
97109
name: Test on ${{ matrix.platform }}
@@ -118,7 +130,7 @@ jobs:
118130

119131
publish:
120132
name: Publish a release
121-
runs-on: "ubuntu-18.04"
133+
runs-on: "ubuntu-22.04"
122134
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
123135
needs:
124136
- build

0 commit comments

Comments
 (0)