Update TypeScript

Mockttp now exposes some types that use Omit, so we need
at least 3.5+. Good to do anyway, although it required
a couple of other changes en route.

Author: pimterry

pack.ts

@@ -7,7 +7,7 @@ const OUTPUT_DIR = path.join(__dirname, 'build');
 
 const pjson = require(path.join(__dirname, './package.json'));
 
-const spawn = (command: string, args: string[] = [], options?: SpawnOptions) => {
+const spawn = (command: string, args: string[] = [], options: SpawnOptions = {}) => {
     return new Promise((resolve, reject) => {
         const proc = spawnAsync(command, args, options);
         proc.on('exit', (code) => {

package-lock.json

@@ -60,7 +60,7 @@
     "@types/fs-extra": "^8.0.0",
     "@types/lodash": "^4.14.117",
     "@types/mocha": "^5.2.5",
-    "@types/node": "^10.12.0",
+    "@types/node": "^12.7.9",
     "@types/request-promise-native": "^1.0.15",
     "@types/rimraf": "^2.0.2",
     "@types/tmp": "0.0.33",
@@ -85,8 +85,8 @@
     "tarball-extract": "0.0.6",
     "tmp": "0.0.33",
     "ts-loader": "^6.0.0",
-    "ts-node": "^7.0.1",
-    "typescript": "^3.1.3",
+    "ts-node": "^8.4.1",
+    "typescript": "^3.6.3",
     "uglifyjs-webpack-plugin": "^2.2.0",
     "unirest": "^0.6.0",
     "webpack": "^4.40.2",

package.json

@@ -71,7 +71,7 @@ export function initErrorTracking() {
             };
 
             addBreadcrumb('Spawning process', { data: { command, args, options: sanitizedOptions } });
-            return rawSpawn.apply(this, arguments);
+            return rawSpawn.apply(this, arguments as any);
         };
 
         sentryInitialized = true;

src/error-tracking.ts

@@ -67,8 +67,8 @@ export class FreshChrome implements Interceptor {
             ]
         }, this.config.configPath);
 
-        browser.process.stdout.pipe(process.stdout);
-        browser.process.stderr.pipe(process.stderr);
+        if (browser.process.stdout) browser.process.stdout.pipe(process.stdout);
+        if (browser.process.stderr) browser.process.stderr.pipe(process.stderr);
 
         await hideWarningServer.completedPromise;
         await hideWarningServer.stop();

src/interceptors/fresh-chrome.ts

@@ -119,8 +119,8 @@ export class FreshFirefox implements Interceptor {
             })
         }, this.config.configPath);
 
-        browser.process.stdout.pipe(process.stdout);
-        browser.process.stderr.pipe(process.stderr);
+        if (browser.process.stdout) browser.process.stdout.pipe(process.stdout);
+        if (browser.process.stderr) browser.process.stderr.pipe(process.stderr);
 
         let success = false;
         certCheckServer.waitForSuccess().then(() => {

src/interceptors/fresh-firefox.ts

@@ -58,13 +58,13 @@ describe('Integration test', function () {
         stderr = "";
 
         return new Promise((resolve, reject) => {
-            serverProcess.stdout.on('data', (d) => {
+            serverProcess.stdout!.on('data', (d) => {
                 if (d.includes('Server started')) resolve();
                 stdout = stdout + d.toString();
                 console.log(d.toString());
             });
 
-            serverProcess.stderr.on('data', (d) => {
+            serverProcess.stderr!.on('data', (d) => {
                 reject();
                 stderr = stderr + d.toString();
                 console.warn(d.toString());