Cleanly close existing Chrom* on Windows

Author: pimterry

src/interceptors/chromium-based-interceptors.ts

@@ -10,7 +10,7 @@ import {
     Browser,
     LaunchOptions
 } from '../browsers';
-import { delay, readFile, deleteFolder, listRunningProcesses } from '../util';
+import { delay, readFile, deleteFolder, listRunningProcesses, windowsClose } from '../util';
 import { HideWarningServer } from '../hide-warning-server';
 import { Interceptor } from '.';
 import { reportError } from '../error-tracking';
@@ -228,7 +228,12 @@ abstract class ExistingChromiumBasedInterceptor implements Interceptor {
                 );
             }
 
-            process.kill(existingPid);
+            if (process.platform === 'win32') {
+                windowsClose(existingPid);
+            } else {
+                process.kill(existingPid);
+            }
+
             await delay(1000);
         }
 

src/util.ts

@@ -167,6 +167,15 @@ export async function listRunningProcesses(): Promise<Array<Proc>> {
     }
 }
 
+// Cleanly close (simulate closing the main window) on a specific windows process
+export async function windowsClose(pid: number) {
+    await spawnToResult('taskkill', [
+        '/pid', pid.toString(),
+    ]);
+}
+
+// Harshly kill a windows process by some WMIC matching string e.g.
+// "processId=..." or "CommandLine Like '%...%'"
 export async function windowsKill(processMatcher: string) {
     await spawnToResult('wmic', [
         'Path', 'win32_process',