Persist the firefox profile, as long as setup was successful.

This depends on https://github.com/httptoolkit/james-browser-launcher/commit/02c8a1f4ad9e6fad8c9dfa1ed0a962c77f29985b
which adds this functionality to james-browser-launcher. In the meantime,
this will continue to work as previously.

Author: pimterry

custom-typings/@james-proxy/index.d.ts

@@ -16,6 +16,7 @@ declare module '@james-proxy/james-browser-launcher' {
             noProxy?: string | string[];
             headless?: boolean;
             prefs?: { [key: string]: any };
+            profile?: string;
         }
 
         function Launch(

package-lock.json

@@ -26,10 +26,12 @@
     "@oclif/plugin-help": "^2.1.3",
     "@types/env-paths": "^1.0.2",
     "@types/lodash": "^4.14.117",
+    "@types/rimraf": "^2.0.2",
     "env-paths": "^1.0.0",
     "graphql-yoga": "^1.16.7",
     "lodash": "^4.17.11",
     "mockttp": "^0.11.0",
+    "rimraf": "^2.6.2",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

package.json

@@ -17,14 +17,19 @@ let installingCert: boolean;
 function ensureCertificateIsInstalled() {
     const testUrl = window.location.href.replace('http://', 'https://').replace('check-cert', 'test-https');
     const downloadUrl = window.location.href.replace('check-cert', 'download-cert');
+    const reportSuccessUrl = window.location.href.replace('check-cert', 'report-success');
 
     fetch(testUrl)
         .then(() => true)
         .catch(() => false)
         .then((certificateIsTrusted) => {
             if (certificateIsTrusted) {
-                window.location.replace(targetUrl);
+                // Report success (ignoring errors) then continue.
+                fetch(reportSuccessUrl).catch(() => {}).then(() => {
+                    window.location.replace(targetUrl);
+                });
             } else {
+                // Start trying to prompt the user to install the cert
                 if (!installingCert) {
                     installingCert = true;
                     const iframe = document.createElement('iframe');
@@ -136,6 +141,15 @@ export class CertCheckServer {
             .replace(/\/?$/, '/check-cert');
     }
 
+    async waitForSuccess(): Promise<void> {
+        return new Promise<void>((resolve) =>
+            this.server!.get('/report-success').thenCallback(() => {
+                resolve();
+                return { status: 200 };
+            })
+        );
+    }
+
     async stop() {
         if (this.server) {
             await this.server.stop();

src/cert-check-server.ts

@@ -1,10 +1,15 @@
+import { promisify } from 'util';
 import * as _ from 'lodash';
+import * as rimraf from 'rimraf';
+import * as path from 'path';
 
 import { HtkConfig } from '../config';
 
 import { getAvailableBrowsers, launchBrowser, BrowserInstance } from '../browsers';
 import { CertCheckServer } from '../cert-check-server';
 
+const deleteFolder = promisify(rimraf);
+
 let browsers: _.Dictionary<BrowserInstance> = {};
 
 export class FreshFirefox {
@@ -32,11 +37,11 @@ export class FreshFirefox {
         const certCheckServer = new CertCheckServer(this.config);
         await certCheckServer.start('https://amiusing.httptoolkit.tech');
 
-        // TODO: Change james launcher so I can pass a profile here,
-        // so things persist across launches. Permanently? Yes, probably.
+        const firefoxProfile = path.join(this.config.configPath, 'firefox-profile');
 
         const browser = await launchBrowser(certCheckServer.checkCertUrl, {
             browser: 'firefox',
+            profile: firefoxProfile,
             proxy: `localhost:${proxyPort}`,
             // Don't intercept our cert testing requests
             noProxy: certCheckServer.host,
@@ -60,8 +65,6 @@ export class FreshFirefox {
                 "browser.tabs.warnOnClose": false,
                 "browser.tabs.warnOnCloseOtherTabs": false,
 
-                // Disable 'new FF available' messages
-
                 // Disable various first-run things:
                 "browser.uitour.enabled": false,
                 'browser.usedOnWindows10': true,
@@ -75,10 +78,18 @@ export class FreshFirefox {
             }
         }, this.config.configPath);
 
+        let success = false;
+        certCheckServer.waitForSuccess().then(() => {
+            success = true;
+        }).catch(console.warn);
+
         browsers[proxyPort] = browser;
         browser.process.once('exit', () => {
             certCheckServer.stop();
             delete browsers[proxyPort];
+            if (!success) {
+                deleteFolder(firefoxProfile).catch(console.warn);
+            }
         });
     }