Skip to content

Commit 844b267

Browse files
committed
Make TLS error info a little clearer that it could be _our_ fault
Most of the time it's not, but in some niche cases your TLS configuration on the settings page could be broken (loading a PFX containing certs with legacy algorithms) in which case we do need to consider the possibility that might be the issue.
1 parent c2c9c2e commit 844b267

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/components/send/sent-response-error.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,15 @@ export const SentResponseError = (props: {
7070
: errorType === 'untrusted'
7171
? 'has an untrusted HTTPS certificate'
7272
: errorType === 'tls-error'
73-
? 'failed to complete a TLS handshake'
73+
? 'could not complete a TLS handshake'
7474
: errorType === 'host-unreachable'
7575
? 'was not reachable on your network connection'
7676
: errorType === 'host-not-found' || errorType === 'dns-error'
7777
? 'hostname could not be found'
7878
: errorType === 'connection-refused'
7979
? 'refused the connection'
8080
: unreachableCheck(errorType)
81-
}, so HTTP Toolkit did not send the request.
81+
}, so HTTP Toolkit didn't send the request.
8282
</ExplanationBlock>
8383
: wasServerIssue(errorType)
8484
? <ExplanationBlock>

src/components/view/http/http-error-header.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,15 @@ export const HttpErrorHeader = (p: {
8888
: p.type === 'untrusted'
8989
? 'has an untrusted HTTPS certificate'
9090
: p.type === 'tls-error'
91-
? 'failed to complete a TLS handshake'
91+
? 'could not complete a TLS handshake'
9292
: p.type === 'host-unreachable'
9393
? 'was not reachable on your network connection'
9494
: p.type === 'host-not-found' || p.type === 'dns-error'
9595
? 'hostname could not be found'
9696
: p.type === 'connection-refused'
9797
? 'refused the connection'
9898
: unreachableCheck(p.type)
99-
}, so HTTP Toolkit did not forward the request.
99+
}, so HTTP Toolkit didn't forward the request.
100100
</>
101101
: wasTimeout(p.type)
102102
? <>
@@ -135,15 +135,15 @@ export const HttpErrorHeader = (p: {
135135
{ p.type === 'tls-error'
136136
? <>
137137
<HeaderText>
138-
This could be caused by the server not supporting modern cipher
139-
standards or TLS versions, requiring a client certificate that hasn't
140-
been provided, or other TLS configuration issues.
138+
This could be caused by the server not supporting modern ciphers or
139+
TLS versions, expecting a client certificate that wasn't provided,
140+
or TLS configuration issues in either the server or HTTP Toolkit.
141141
</HeaderText>
142142
<HeaderText>
143143
{ p.isPaidUser
144144
? <>
145145
From the Settings page you can configure client certificates, or
146-
whitelist this host to relax HTTPS requirements and allow
146+
whitelist this host to relax security requirements and allow
147147
self-signed certificates, which may resolve some TLS issues.
148148
</>
149149
: <>

0 commit comments

Comments
 (0)