Skip to content

Commit 92b44c2

Browse files
committed
Improve semantic structure for URL breakdowns
1 parent ad82d86 commit 92b44c2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/components/view/url-breakdown.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@ import * as React from 'react';
33
import { styled } from '../../styles';
44
import { ContentLabel } from '../common/text-content';
55

6-
const BreakdownContainer = styled.div`
6+
const BreakdownContainer = styled.dl`
77
display: grid;
88
grid-template-columns: fit-content(50%) auto;
99
grid-gap: 5px;
1010
`;
1111

12-
const BreakdownKey = styled.div`
12+
const BreakdownKey = styled.dt`
1313
font-family: ${p => p.theme.monoFontFamily};
1414
word-break: break-all;
1515
text-align: right;
1616
`;
1717

18-
const BreakdownValue = styled.pre`
18+
const BreakdownValue = styled.dd`
1919
font-family: ${p => p.theme.monoFontFamily};
2020
word-break: break-all;
2121
white-space: pre-wrap;
@@ -36,7 +36,7 @@ export const UrlBreakdown = (p: { url: URL }) => {
3636
decodedPathname = p.url.pathname;
3737
}
3838

39-
return <BreakdownContainer>
39+
return <BreakdownContainer role='region'>
4040
<BreakdownKey>Protocol:</BreakdownKey> <BreakdownValue>{ p.url.protocol.slice(0, -1) }</BreakdownValue>
4141

4242
{ (p.url.username || p.url.password) && <>

0 commit comments

Comments
 (0)