change setTimeout usages to callback functions and remove vestigial code

Signed-off-by: Matt Nelson <[email protected]>

Author: metheos

src/components/view/view-event-list.tsx

@@ -769,6 +769,17 @@ export class ViewEventList extends React.Component<ViewEventListProps> {
     private listBodyRef = React.createRef<HTMLDivElement>();
     private listRef = React.createRef<List>();
 
+    private setListBodyRef = (element: HTMLDivElement | null) => {
+        // Update the ref
+        (this.listBodyRef as any).current = element;
+        
+        // If the element is being mounted and we haven't restored state yet, do it now
+        if (element && !this.hasRestoredInitialState) {
+            this.restoreScrollPosition();
+            this.hasRestoredInitialState = true;
+        }
+    };
+
     private KeyBoundListWindow = observer(
         React.forwardRef<HTMLDivElement>(
             (props: any, ref) => <div
@@ -818,7 +829,7 @@ export class ViewEventList extends React.Component<ViewEventListProps> {
                 : <AutoSizer>{({ height, width }) =>
                     <Observer>{() =>
                         <List
-                            innerRef={this.listBodyRef}
+                            innerRef={this.setListBodyRef}
                             outerElementType={this.KeyBoundListWindow}
                             ref={this.listRef}
 
@@ -896,21 +907,8 @@ export class ViewEventList extends React.Component<ViewEventListProps> {
         });
     }
 
-    private hasRestoredInitialState = false;    
-    componentDidMount() {
-        // Don't save scroll state immediately - wait until we've restored first
-        
-        // Use a more aggressive delay to ensure DOM is fully ready
-        setTimeout(() => {
-            this.restoreScrollPosition();
-            
-            // Only start tracking scroll changes after we've restored
-            setTimeout(() => {
-                this.hasRestoredInitialState = true;
-            }, 100);
-        }, 100);
-    }
-
+    private hasRestoredInitialState = false;
+    
     componentDidUpdate(prevProps: ViewEventListProps) {
         if (this.listBodyRef.current?.parentElement?.contains(document.activeElement)) {
             // If we previously had something here focused, and we've updated, update

src/components/view/view-page.tsx

@@ -171,6 +171,9 @@ class ViewPage extends React.Component<ViewPageProps> {
 
     private listRef = React.createRef<ViewEventList>();
     private splitPaneRef = React.createRef<SplitPane>();
+    
+    @observable
+    private shouldRestoreViewStateOnRefSet = false;
 
     @observable
     private searchFiltersUnderConsideration: FilterSet | undefined;
@@ -248,10 +251,8 @@ class ViewPage extends React.Component<ViewPageProps> {
             if (this.props.eventId && this.selectedEvent) {
                 this.onScrollToCenterEvent(this.selectedEvent);
             } else if (!this.props.eventId && this.props.uiStore.selectedEventId) {
-                // If no URL eventId but we have a persisted selection, restore it
-                setTimeout(() => {
-                    this.listRef.current?.restoreViewState();
-                }, 100);
+                // If no URL eventId but we have a persisted selection, restore it when ref is set
+                this.shouldRestoreViewStateOnRefSet = true;
             } else {
                 this.onScrollToEnd();
             }
@@ -333,9 +334,6 @@ class ViewPage extends React.Component<ViewPageProps> {
             })
         );
     }
-    componentWillUnmount() {
-        // Component is unmounting
-    }
 
     componentDidUpdate(prevProps: ViewPageProps) {
         // Only clear persisted selection if we're explicitly navigating to a different event via URL
@@ -468,7 +466,7 @@ class ViewPage extends React.Component<ViewPageProps> {
                         contextMenuBuilder={this.contextMenuBuilder}
                         uiStore={this.props.uiStore}
 
-                        ref={this.listRef}
+                        ref={this.setListRef}
                     />
                 </LeftPane>
                 <PaneOuterContainer
@@ -642,6 +640,19 @@ class ViewPage extends React.Component<ViewPageProps> {
     onScrollToEnd() {
         this.listRef.current?.scrollToEnd();
     }
+
+    @action.bound
+    setListRef = (ref: ViewEventList | null) => {
+        if (ref) {
+            (this.listRef as any).current = ref;
+            if (this.shouldRestoreViewStateOnRefSet) {
+                this.shouldRestoreViewStateOnRefSet = false;
+                ref.restoreViewState();
+            }
+        } else {
+            (this.listRef as any).current = null;
+        }
+    };
 }
 
 const LeftPane = styled.div`