Show UTF-8 but 'binary' stream messages as text by default

Author: pimterry

src/model/events/stream-message.ts

@@ -1,7 +1,7 @@
 import { computed, observable } from 'mobx';
 
 import { InputStreamMessage } from "../../types";
-import { asBuffer } from '../../util/buffer';
+import { asBuffer, isProbablyUtf8 } from '../../util/buffer';
 import { ObservableCache } from '../observable-cache';
 import { isProbablyJson, isProbablyJsonRecords } from '../../util/json';
 
@@ -44,7 +44,7 @@ export class StreamMessage {
     }
 
     get contentType() {
-        if (this.inputMessage.isBinary) {
+        if (this.inputMessage.isBinary && !isProbablyUtf8(this.inputMessage.content)) {
             if (this.subprotocol?.includes('proto')) {
                 return 'protobuf';
             } else {

src/util/buffer.ts

@@ -21,8 +21,8 @@ const binaryLaxDecoder = new TextDecoder('latin1', { fatal: false });
 // raw binary data). For viewing content as text we don't care (we just always show
 // as UTF8) but for _editing_ binary data we need a lossless encoding, not utf8.
 // (Monaco isn't perfectly lossless editing binary anyway, but we can try).
-export function isProbablyUtf8(buffer: Buffer) {
-    let dataToCheck: Buffer;
+export function isProbablyUtf8(buffer: Uint8Array) {
+    let dataToCheck: Uint8Array;
     if (buffer.byteLength > 1028) {
         // We want to trim the data to ~1KB, to avoid checking huge bodies in full.
         // Unfortunately, for UTF-8 this isn't safe: if a multibyte char crosses the