Skip to content

Commit e175202

Browse files
committed
Tweak duration pill precision slightly
Trying to reduce needlessly precise values that look weird, and aggressive churn of values when watching pending numbers tick upwards.
1 parent aefe094 commit e175202

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/components/common/duration-pill.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import { observableClock } from '../../util/observable';
66

77
import { Pill } from './pill';
88

9-
function sigFig(num: number, figs: number): number {
10-
return parseFloat(num.toFixed(figs));
9+
function sigFig(num: number, figs: number): string {
10+
return num.toFixed(figs);
1111
}
1212

1313
type DurationPillProps = { className?: string } & (
@@ -42,9 +42,10 @@ export const DurationPill = observer((p: DurationPillProps) => {
4242
if (duration === undefined) return null;
4343

4444
return <Pill className={p.className}>{
45-
duration < 100 ? sigFig(duration, 2) + 'ms' : // 22.34ms
46-
duration < 1000 ? sigFig(duration, 1) + 'ms' : // 999.5ms
47-
duration < 10000 ? sigFig(duration / 1000, 3) + ' seconds' : // 3.045 seconds
48-
sigFig(duration / 1000, 1) + ' seconds' // 11.2 seconds
45+
duration < 100 ? sigFig(duration, 1) + 'ms' : // 22.3ms
46+
duration < 1000 ? sigFig(duration, 0) + 'ms' : // 999ms
47+
duration < 5000 ? sigFig(duration / 1000, 2) + ' seconds' : // 3.04 seconds
48+
duration < 9900 ? sigFig(duration / 1000, 1) + ' seconds' : // 8.2 seconds
49+
sigFig(duration / 1000, 0) + ' seconds' // 30 seconds
4950
}</Pill>;
5051
});

0 commit comments

Comments
 (0)