Skip to content

Commit f84e3c8

Browse files
committed
Fix non-functional aria label on the Intercept search box
1 parent 3ec136b commit f84e3c8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/components/common/search-box.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export const SearchBox = styled((props: {
3636
className?: string,
3737
value: string,
3838
placeholder?: string,
39+
'aria-label'?: string,
3940
autoFocus?: boolean,
4041
onSearch: (input: string) => void,
4142
iconSize?: SizeProp
@@ -45,6 +46,7 @@ export const SearchBox = styled((props: {
4546
autoFocus={props.autoFocus}
4647
value={props.value}
4748
placeholder={props.placeholder}
49+
aria-label={props['aria-label']}
4850
onChange={(e) => props.onSearch(e.currentTarget.value)}
4951
/>
5052
<ClearSearchButton

src/components/intercept/intercept-page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ const InterceptInstructions = styled.div`
8989
const InterceptSearchBox = styled(SearchBox).attrs(() => ({
9090
autoFocus: true,
9191
placeholder: 'Browsers, mobile, docker...',
92+
'aria-label': "Filter the list of intercept options below",
9293
iconSize: '2x'
9394
}))`
9495
@media (min-width: ${NARROW_LAYOUT_BREAKPOINT}px) {
@@ -138,7 +139,6 @@ class InterceptPage extends React.Component<InterceptPageProps> {
138139
search for connectors that could work for you:
139140
</p>
140141
<InterceptSearchBox
141-
aria-label="Filter the list of intercept options below"
142142
value={this.filter || ''}
143143
onSearch={this.onSearchInput}
144144
/>

0 commit comments

Comments
 (0)