Stop officially supporting Node v10 (still works, but may break in future)

Node v10 is now past its final end-of-life date and is unsupported.
Nothing breaks with Node v10 right now, but things may begin breaking
in any future release with no warning, and the tests no longer
include workarounds to handle v10 in test case code.

Author: pimterry

.github/workflows/ci.yml

@@ -7,7 +7,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x, v16.2, '*']
+        node-version: [12.x, 14.x, v16.2, '*']
 
     steps:
       - uses: actions/checkout@v2

package.json

@@ -118,7 +118,7 @@
     "webpack": "^4.46.0"
   },
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=12.0.0"
   },
   "dependencies": {
     "@graphql-tools/schema": "^7.1.5",

test/integration/proxy.spec.ts

@@ -20,9 +20,7 @@ import {
     startDnsServer,
     destroyable,
     DestroyableServer,
-    H2_TLS_ON_TLS_SUPPORTED,
-    TLS_MIN_VERSION_SUPPORTED,
-    ZLIB_BROTLI_AVAILABLE
+    H2_TLS_ON_TLS_SUPPORTED
 } from "../test-utils";
 import { generateCACertificate, CA } from "../../src/util/tls";
 import { isLocalIPv6Available } from "../../src/util/socket-util";
@@ -740,9 +738,7 @@ nodeOnly(() => {
                     let oldServerPort: number;
                     let oldServer: DestroyableServer;
 
-                    beforeEach(async function () {
-                        if (!semver.satisfies(process.version, TLS_MIN_VERSION_SUPPORTED)) this.skip();
-
+                    beforeEach(async () => {
                         const caKey = await fs.readFile('./test/fixtures/test-ca.key');
                         const caCert = await fs.readFile('./test/fixtures/test-ca.pem');
                         const ca = new CA(caKey, caCert, 1024);
@@ -2125,9 +2121,7 @@ nodeOnly(() => {
                 });
             });
 
-            it("can update a JSON body while handling encoding automatically", async function () {
-                if (!semver.satisfies(process.version, ZLIB_BROTLI_AVAILABLE)) this.skip();
-
+            it("can update a JSON body while handling encoding automatically", async () => {
                 await server.anyRequest().thenPassThrough({
                     transformResponse: {
                         updateHeaders: {

test/integration/subscriptions/tls-error-events.spec.ts

@@ -87,8 +87,7 @@ describe("TLS error subscriptions", () => {
 
         expect(tlsError.failureCause).to.be.oneOf([
             // Depends on specific client behaviour:
-            'reset', // Node 12
-            'closed', // Node 10
+            'reset', // Node 12+
             'cert-rejected' // Chrome
         ]);
         expect(tlsError.hostname).to.equal('localhost');
@@ -119,8 +118,7 @@ describe("TLS error subscriptions", () => {
 
         expect(tlsError.failureCause).to.be.oneOf([
             // Depends on specific client behaviour:
-            'reset', // Node 12
-            'closed', // Node 10
+            'reset', // Node 12+
             'cert-rejected' // Chrome
         ]);
 
@@ -146,11 +144,7 @@ describe("TLS error subscriptions", () => {
 
             const tlsError = await seenTlsErrorPromise;
 
-            expect(tlsError.failureCause).to.be.oneOf([
-                // Depends on specific client behaviour:
-                'reset', // Node 12+
-                'closed', // Node 10-
-            ]);
+            expect(tlsError.failureCause).to.be.equal('reset');
             expect(tlsError.hostname).to.equal('localhost');
             expect(tlsError.remoteIpAddress).to.equal('::ffff:127.0.0.1');
             expect(tlsError.remotePort).to.be.greaterThan(0);

test/test-utils.ts

@@ -196,8 +196,6 @@ export async function startDnsServer(callback: (question: dns2.DnsQuestion) => s
 }
 
 export const H2_TLS_ON_TLS_SUPPORTED = ">=12.17";
-export const TLS_MIN_VERSION_SUPPORTED = ">=12";
-export const ZLIB_BROTLI_AVAILABLE = ">=12";
 
 type Http2ResponseHeaders = http2.IncomingHttpHeaders & http2.IncomingHttpStatusHeader;