Fix bug: when all the requests is shor-circuited, failure rate is 100%

humingcheng · humingcheng · commit a50524e6c49e · 2018-07-06T17:12:45.000+08:00
diff --git a/monitorData.go b/monitorData.go
@@ -121,11 +121,10 @@ func (monitorData *MonitorData) appendInterfaceInfo(name string, i interface{})
 			interfaceInfo.Latency = int(t.Mean() / float64(time.Millisecond))
 		}
 	}
+	interfaceInfo.Rate = 1 //rate is no use any more and must be set to 1
 	if interfaceInfo.Total == 0 {
-		interfaceInfo.Rate = 100
 		interfaceInfo.FailureRate = 0
 	} else {
-		interfaceInfo.Rate = float64(interfaceInfo.successCount) / float64(interfaceInfo.Total)
 		totalErrorCount := interfaceInfo.Failure + interfaceInfo.SemaphoreRejected + interfaceInfo.ThreadPoolRejected + interfaceInfo.CountTimeout
 		if totalErrorCount == 0 {
 			interfaceInfo.FailureRate = 0

Original file line number	Diff line number	Diff line change
`@@ -121,11 +121,10 @@ func (monitorData *MonitorData) appendInterfaceInfo(name string, i interface{})`
`121`	`121`	`interfaceInfo.Latency = int(t.Mean() / float64(time.Millisecond))`
`122`	`122`	`}`
`123`	`123`	`}`
	`124`	`+ interfaceInfo.Rate = 1 //rate is no use any more and must be set to 1`
`124`	`125`	`if interfaceInfo.Total == 0 {`
`125`		`- interfaceInfo.Rate = 100`
`126`	`126`	`interfaceInfo.FailureRate = 0`
`127`	`127`	`} else {`
`128`		`- interfaceInfo.Rate = float64(interfaceInfo.successCount) / float64(interfaceInfo.Total)`
`129`	`128`	`totalErrorCount := interfaceInfo.Failure + interfaceInfo.SemaphoreRejected + interfaceInfo.ThreadPoolRejected + interfaceInfo.CountTimeout`
`130`	`129`	`if totalErrorCount == 0 {`
`131`	`130`	`interfaceInfo.FailureRate = 0`