update code for create repository from template

Signed-off-by: Yang Ting <[email protected]>

Author: bonnie-young

src/main/java/org/kohsuke/github/GHCreateRepositoryBuilder.java

@@ -13,7 +13,7 @@
 public class GHCreateRepositoryBuilder {
     private final GitHub root;
     protected final Requester builder;
-    private final String apiUrlTail;
+    private String apiUrlTail;
 
     GHCreateRepositoryBuilder(GitHub root, String apiUrlTail, String name) {
         this.root = root;
@@ -22,22 +22,6 @@ public class GHCreateRepositoryBuilder {
         this.builder.with("name", name);
     }
 
-    GHCreateRepositoryBuilder(GitHub root, String apiUrlTail, String name, Boolean isTemplate) {
-        this.root = root;
-        this.apiUrlTail = apiUrlTail;
-        this.builder = root.createRequest();
-        this.builder.with("name", name);
-        this.builder.with("is_template", isTemplate);
-    }
-
-    GHCreateRepositoryBuilder(GitHub root, String apiUrlTail, String name, String owner) {
-        this.root = root;
-        this.apiUrlTail = apiUrlTail;
-        this.builder = root.createRequest();
-        this.builder.with("name", name);
-        this.builder.with("owner", owner);
-    }
-
     /**
      * Description for repository
      *
@@ -219,25 +203,59 @@ public GHCreateRepositoryBuilder team(GHTeam team) {
     }
 
     /**
-     * Creates a repository with all the parameters.
+     * Specifies whether the repository is a template.
      *
-     * @return the gh repository
-     * @throws IOException
-     *             if repsitory cannot be created
+     * @param enabled
+     *            true if enabled
+     * @return a builder to continue with building
      */
-    public GHRepository create() throws IOException {
-        return builder.method("POST").withUrlPath(apiUrlTail).fetch(GHRepository.class).wrap(root);
+    @Preview
+    @Deprecated
+    public GHCreateRepositoryBuilder templateRepository(boolean enabled) {
+        this.builder.withPreview(BAPTISE);
+        this.builder.with("is_template", enabled);
+        return this;
+    }
+
+    /**
+     * Specifies the ownership of the repository.
+     *
+     * @param owner
+     *            organization or personage
+     * @return a builder to continue with building
+     */
+    public GHCreateRepositoryBuilder owner(String owner) {
+        this.builder.with("owner", owner);
+        return this;
     }
 
     /**
-     * Creates a repository with all the parameters, and with Preview BAPTISE for template repo.
+     * Create repository from template repository.
+     *
+     * @param templateOwner
+     *            template repository owner
+     * @param templateRepo
+     *            template repository
+     * @return a builder to continue with building
+     * @see <a href="https://developer.github.com/v3/previews/">GitHub API Previews</a>
+     */
+    @Preview
+    @Deprecated
+    public GHCreateRepositoryBuilder fromTemplateRepository(String templateOwner, String templateRepo) {
+        this.builder.withPreview(BAPTISE);
+        this.apiUrlTail = "/repos/" + templateOwner + "/" + templateRepo + "/generate";
+        return this;
+    }
+
+    /**
+     * Creates a repository with all the parameters.
      *
      * @return the gh repository
      * @throws IOException
      *             if repsitory cannot be created
      */
-    public GHRepository createWithTemplate() throws IOException {
-        return builder.method("POST").withPreview(BAPTISE).withUrlPath(apiUrlTail).fetch(GHRepository.class).wrap(root);
+    public GHRepository create() throws IOException {
+        return builder.method("POST").withUrlPath(apiUrlTail).fetch(GHRepository.class).wrap(root);
     }
 
 }

src/main/java/org/kohsuke/github/GHOrganization.java

@@ -100,50 +100,6 @@ public GHCreateRepositoryBuilder createRepository(String name) {
         return new GHCreateRepositoryBuilder(root, "/orgs/" + login + "/repos", name);
     }
 
-    /**
-     * Starts a builder that creates a new repository.
-     *
-     * <p>
-     * You use the returned builder to set various properties, then call {@link GHCreateRepositoryBuilder#create()} to
-     * finally create a repository.
-     *
-     * @param name
-     *            the name
-     * @param isTemplate
-     *            the is_template
-     * @return the gh create repository builder
-     */
-    public GHCreateRepositoryBuilder createRepositoryWithParametersIsTemplate(String name, Boolean isTemplate) {
-        return new GHCreateRepositoryBuilder(root, "/orgs/" + login + "/repos", name, isTemplate);
-    }
-
-    /**
-     * Starts a builder that creates a new repository.
-     *
-     * <p>
-     * You use the returned builder to set various properties, then call
-     * {@link GHCreateRepositoryBuilder#createWithTemplate()} to finally create a repository.
-     *
-     * @param templateOwner
-     *            the owner of template repository
-     * @param templateRepo
-     *            the template repository
-     * @param name
-     *            the name of repository to be created
-     * @param owner
-     *            the organization of repository to be created
-     * @return the gh create repository builder
-     */
-    public GHCreateRepositoryBuilder createRepositoryWithTemplate(String templateRepo,
-            String templateOwner,
-            String name,
-            String owner) {
-        return new GHCreateRepositoryBuilder(root,
-                "/repos/" + templateOwner + "/" + templateRepo + "/generate",
-                name,
-                owner);
-    }
-
     /**
      * Teams by their names.
      *

src/test/java/org/kohsuke/github/GHOrganizationTest.java

@@ -58,17 +58,17 @@ public void testCreateRepositoryWithAutoInitialization() throws IOException {
     }
 
     @Test
-    public void testCreateRepositoryWithParametersIsTemplate() throws IOException {
-        cleanupRepository(GITHUB_API_TEST_ORG + '/' + GITHUB_API_TEMPLATE_TEST);
+    public void testCreateRepositoryWithParameterIsTemplate() throws IOException {
+        cleanupRepository(GITHUB_API_TEST_ORG + '/' + GITHUB_API_TEST);
 
         GHOrganization org = gitHub.getOrganization(GITHUB_API_TEST_ORG);
-        GHRepository repository = org.createRepositoryWithParametersIsTemplate(GITHUB_API_TEMPLATE_TEST, true)
+        GHRepository repository = org.createRepository(GITHUB_API_TEMPLATE_TEST)
                 .description("a test template repository used to test kohsuke's github-api")
                 .homepage("http://github-api.kohsuke.org/")
                 .team(org.getTeamByName("Core Developers"))
                 .autoInit(true)
+                .templateRepository(true)
                 .create();
-
         Assert.assertNotNull(repository);
         Assert.assertNotNull(repository.getReadme());
     }
@@ -78,12 +78,10 @@ public void testCreateRepositoryWithTemplate() throws IOException {
         cleanupRepository(GITHUB_API_TEST_ORG + '/' + GITHUB_API_TEST);
 
         GHOrganization org = gitHub.getOrganization(GITHUB_API_TEST_ORG);
-        GHRepository repository = org
-                .createRepositoryWithTemplate(GITHUB_API_TEMPLATE_TEST,
-                        GITHUB_API_TEST_ORG,
-                        GITHUB_API_TEST,
-                        GITHUB_API_TEST_ORG)
-                .createWithTemplate();
+        GHRepository repository = org.createRepository(GITHUB_API_TEST)
+                .fromTemplateRepository(GITHUB_API_TEST_ORG, GITHUB_API_TEMPLATE_TEST)
+                .owner(GITHUB_API_TEST_ORG)
+                .create();
 
         Assert.assertNotNull(repository);
         Assert.assertNotNull(repository.getReadme());

src/test/resources/org/kohsuke/github/GHOrganizationTest/wiremock/testCreateRepositoryWithParametersIsTemplate/__files/orgs_hub4j-test-org-2.json renamed to src/test/resources/org/kohsuke/github/GHOrganizationTest/wiremock/testCreateRepositoryWithParameterIsTemplate/__files/orgs_hub4j-test-org-2.json

@@ -13,7 +13,7 @@
     ],
     "headers": {
       "Accept": {
-        "equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
+        "equalTo": "application/vnd.github.baptiste-preview+json"
       }
     }
   },