rename 'fetchAssets' to 'listAssets' and return PagedIterable

Author: skaldarnar

src/main/java/org/kohsuke/github/GHRelease.java

@@ -272,12 +272,12 @@ public List<GHAsset> getCachedAssets() {
      * @throws IOException
      *             the io exception
      * @deprecated The behavior of this method will change in a future release. It will then provide cached assets as
-     *             provided by {@link #getCachedAssets()}. Use {@link #fetchAssets()} instead to fetch up-to-date
+     *             provided by {@link #getCachedAssets()}. Use {@link #listAssets()} instead to fetch up-to-date
      *             information of assets.
      */
     @Deprecated
     public List<GHAsset> getAssets() throws IOException {
-        return fetchAssets();
+        return listAssets().toList();
     }
 
     /**
@@ -287,11 +287,10 @@ public List<GHAsset> getAssets() throws IOException {
      * @throws IOException
      *             the io exception
      */
-    public List<GHAsset> fetchAssets() throws IOException {
+    public PagedIterable<GHAsset> listAssets() throws IOException {
         Requester builder = owner.root.createRequest();
         return builder.withUrlPath(getApiTailUrl("assets"))
-                .toIterable(GHAsset[].class, item -> item.wrap(this))
-                .toList();
+                .toIterable(GHAsset[].class, item -> item.wrap(this));
     }
 
     /**

src/test/java/org/kohsuke/github/LifecycleTest.java

@@ -45,7 +45,7 @@ public void testCreateRepository() throws IOException {
 
     private void updateAsset(GHRelease release, GHAsset asset) throws IOException {
         asset.setLabel("test label");
-        assertEquals("test label", release.fetchAssets().get(0).getLabel());
+        assertEquals("test label", release.getAssets().get(0).getLabel());
     }
 
     private void deleteAsset(GHRelease release, GHAsset asset) throws IOException {
@@ -58,7 +58,7 @@ private GHAsset uploadAsset(GHRelease release) throws IOException {
         assertNotNull(asset);
         List<GHAsset> cachedAssets = release.getCachedAssets();
         assertEquals(0, cachedAssets.size());
-        List<GHAsset> assets = release.fetchAssets();
+        List<GHAsset> assets = release.getAssets();
         assertEquals(1, assets.size());
         assertEquals("LICENSE.txt", assets.get(0).getName());