Add test coverage for OkHttpConnector

Author: bitwiseman

pom.xml

@@ -153,10 +153,6 @@
                       </limit>
                     </limits>
                     <excludes>
-                      <!-- Code implemented externally -->
-                      <exclude>org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory.**</exclude>
-                      <exclude>org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory</exclude>
-
                       <!-- Sample only -->
                       <exclude>org.kohsuke.github.example.*</exclude>
 
@@ -575,6 +571,17 @@
           <plugin>
             <artifactId>maven-surefire-plugin</artifactId>
             <executions>
+              <execution>
+                <id>okhttp-test</id>
+                <phase>test</phase>
+                <goals>
+                  <goal>test</goal>
+                </goals>
+                <configuration>
+                  <excludesFile>src/test/resources/slow-or-flaky-tests.txt</excludesFile>
+                  <argLine>@{jacoco.surefire.argLine} ${surefire.argLine} -Dtest.github.useOkHttp</argLine>
+                </configuration>
+              </execution>
               <execution>
                 <id>slow-or-flaky-test</id>
                 <phase>test</phase>

src/main/java/org/kohsuke/github/GitHubConnector.java

@@ -1,5 +1,8 @@
 package org.kohsuke.github;
 
+import okhttp3.OkHttpClient;
+import org.kohsuke.github.extras.okhttp3.OkHttpConnector;
+
 import java.io.IOException;
 import java.net.HttpURLConnection;
 import java.net.URL;
@@ -33,7 +36,9 @@ default HttpURLConnection connect(URL url) throws IOException {
     /**
      * Default implementation that uses {@link URL#openConnection()}.
      */
-    GitHubConnector DEFAULT = new GitHubConnectorHttpConnectorAdapter(HttpConnector.DEFAULT);
+    GitHubConnector DEFAULT = (System.getProperty("test.github.useOkHttp", "false") != "false")
+            ? new OkHttpConnector(new OkHttpClient.Builder().build())
+            : new GitHubConnectorHttpConnectorAdapter(HttpConnector.DEFAULT);
 
     GitHubConnector OFFLINE = new GitHubConnectorHttpConnectorAdapter(HttpConnector.OFFLINE);
 }