Skip to content

Commit 689b2f7

Browse files
authored
Apply suggestions from code review
1 parent 81ac480 commit 689b2f7

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

src/main/java/org/kohsuke/github/GHAppInstallation.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,4 @@ public GHAppCreateTokenBuilder createToken(Map<String, GHPermissionType> permiss
365365
public GHAppCreateTokenBuilder createToken() {
366366
return new GHAppCreateTokenBuilder(root, String.format("/app/installations/%d/access_tokens", getId()));
367367
}
368-
369-
GHAppInstallation wrap(GitHub root) {
370-
this.root = root;
371-
return this;
372-
}
373368
}

src/main/java/org/kohsuke/github/GHAppInstallationsIterable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public GHAppInstallation[] next() {
4141
if (result == null) {
4242
result = v;
4343
}
44-
return v.getInstallations(root);
44+
return v.getInstallations();
4545
}
4646
};
4747
}

src/main/java/org/kohsuke/github/GHAppInstallationsPage.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@ public int getTotalCount() {
1111
return total_count;
1212
}
1313

14-
GHAppInstallation[] getInstallations(GitHub root) {
15-
for (GHAppInstallation installation : installations) {
16-
installation.wrap(root);
17-
}
14+
GHAppInstallation[] getInstallations() {
1815
return installations;
1916
}
2017
}

0 commit comments

Comments
 (0)