Update getAppInstallations in GHMyself to return PagedIterable response.

Author: t0m4uk1991

src/main/java/org/kohsuke/github/GHAppInstallations.java

@@ -0,0 +1,48 @@
+package org.kohsuke.github;
+
+import java.net.MalformedURLException;
+import java.util.Iterator;
+
+import javax.annotation.Nonnull;
+
+/**
+ * Iterable for GHAppInstallation listing.
+ */
+class GHAppInstallationsIterable extends PagedIterable<GHAppInstallation> {
+    public static final String APP_INSTALLATIONS_URL = "/user/installations";
+    private final transient GitHub root;
+    private GHAppInstallationsPage result;
+
+    public GHAppInstallationsIterable(GitHub root) {
+        this.root = root;
+    }
+
+    @Nonnull
+    @Override
+    public PagedIterator<GHAppInstallation> _iterator(int pageSize) {
+        try {
+            final GitHubRequest request = root.createRequest().withUrlPath(APP_INSTALLATIONS_URL).build();
+            return new PagedIterator<>(
+                    adapt(GitHubPageIterator.create(root.getClient(), GHAppInstallationsPage.class, request, pageSize)),
+                    null);
+        } catch (MalformedURLException e) {
+            throw new GHException("Malformed URL", e);
+        }
+    }
+
+    protected Iterator<GHAppInstallation[]> adapt(final Iterator<GHAppInstallationsPage> base) {
+        return new Iterator<GHAppInstallation[]>() {
+            public boolean hasNext() {
+                return base.hasNext();
+            }
+
+            public GHAppInstallation[] next() {
+                GHAppInstallationsPage v = base.next();
+                if (result == null) {
+                    result = v;
+                }
+                return v.getInstallations(root);
+            }
+        };
+    }
+}

src/main/java/org/kohsuke/github/GHAppInstallationsIterable.java

@@ -0,0 +1,20 @@
+package org.kohsuke.github;
+
+/**
+ * Represents the one page of GHAppInstallations.
+ */
+class GHAppInstallationsPage {
+    private int total_count;
+    private GHAppInstallation[] installations;
+
+    public int getTotalCount() {
+        return total_count;
+    }
+
+    GHAppInstallation[] getInstallations(GitHub root) {
+        for (GHAppInstallation installation : installations) {
+            installation.wrap(root);
+        }
+        return installations;
+    }
+}

src/main/java/org/kohsuke/github/GHAppInstallationsPage.java

@@ -245,17 +245,12 @@ public GHMembership getMembership(GHOrganization o) throws IOException {
      * use a user-to-server OAuth access token, created for a user who has authorized your GitHub App, to access this
      * endpoint.
      *
-     * @throws IOException
-     *             the io exception
-     * @return list of GHAppInstallation
+     * @return the paged iterable
      * @see <a href=
      *      "https://docs.github.com/en/rest/reference/apps#list-app-installations-accessible-to-the-user-access-token">List
      *      app installations accessible to the user access token</a>
      */
-    public List<GHAppInstallation> getAppInstallations() throws IOException {
-        GHAppInstallations ghAppInstallations = root.createRequest()
-                .withUrlPath("/user/installations")
-                .fetch(GHAppInstallations.class);
-        return ghAppInstallations.getInstallations();
+    public PagedIterable<GHAppInstallation> getAppInstallations() {
+        return new GHAppInstallationsIterable(root);
     }
 }

src/main/java/org/kohsuke/github/GHMyself.java

@@ -389,11 +389,11 @@ public void testGetAppInstallations() throws Exception {
         // To generate test data user-to-server OAuth access token was used
         // For more details pls read
         // https://docs.github.com/en/developers/apps/building-github-apps/identifying-and-authorizing-users-for-github-apps#identifying-users-on-your-site
-        final List<GHAppInstallation> appInstallation = gitHub.getMyself().getAppInstallations();
+        final PagedIterable<GHAppInstallation> appInstallation = gitHub.getMyself().getAppInstallations();
 
-        assertThat(appInstallation, is(not(empty())));
-        assertThat(appInstallation.size(), is(1));
-        final GHAppInstallation ghAppInstallation = appInstallation.get(0);
+        assertThat(appInstallation.toList(), is(not(empty())));
+        assertThat(appInstallation.toList().size(), is(1));
+        final GHAppInstallation ghAppInstallation = appInstallation.toList().get(0);
         assertThat(ghAppInstallation.getAppId(), is(122478L));
         assertThat(ghAppInstallation.getAccount().getLogin(), is("t0m4uk1991"));
     }