Add more coverage for GHCommit methods

Author: bitwiseman

src/main/java/org/kohsuke/github/GHCommit.java

@@ -497,10 +497,7 @@ public PagedIterable<GHBranch> listBranchesWhereHead() throws IOException {
      * @return {@link PagedIterable} with all the commit comments in this repository.
      */
     public PagedIterable<GHCommitComment> listComments() {
-        return owner.root.createRequest()
-                .withUrlPath(
-                        String.format("/repos/%s/%s/commits/%s/comments", owner.getOwnerName(), owner.getName(), sha))
-                .toIterable(GHCommitComment[].class, item -> item.wrap(owner));
+        return owner.listCommitComments(sha);
     }
 
     /**

src/test/java/org/kohsuke/github/AppTest.java

@@ -488,6 +488,16 @@ public void testCommit() throws Exception {
         assertThat(commit.getFiles().size(), equalTo(1));
         assertThat(commit.getHtmlUrl().toString(),
                 equalTo("https://github.com/jenkinsci/jenkins/commit/08c1c9970af4d609ae754fbe803e06186e3206f7"));
+        assertThat(commit.getLinesAdded(), equalTo(40));
+        assertThat(commit.getLinesChanged(), equalTo(48));
+        assertThat(commit.getLinesDeleted(), equalTo(8));
+        assertThat(commit.getParentSHA1s().size(), equalTo(1));
+        assertThat(commit.getAuthoredDate(), equalTo(GitHubClient.parseDate("2012-04-24T00:16:52Z")));
+        assertThat(commit.getCommitDate(), equalTo(GitHubClient.parseDate("2012-04-24T00:16:52Z")));
+        assertThat(commit.getCommitShortInfo().getCommentCount(), equalTo(0));
+        assertThat(commit.getCommitShortInfo().getAuthoredDate(), equalTo(commit.getAuthoredDate()));
+        assertThat(commit.getCommitShortInfo().getCommitDate(), equalTo(commit.getCommitDate()));
+        assertThat(commit.getCommitShortInfo().getMessage(), equalTo("creating an RC branch"));
 
         File f = commit.getFiles().get(0);
         assertThat(f.getLinesChanged(), equalTo(48));
@@ -543,6 +553,8 @@ public void testCreateCommitComment() throws Exception {
         GHCommit commit = gitHub.getUser("kohsuke")
                 .getRepository("sandbox-ant")
                 .getCommit("8ae38db0ea5837313ab5f39d43a6f73de3bd9000");
+
+        assertThat(commit.getCommitShortInfo().getCommentCount(), equalTo(30));
         GHCommitComment c = commit.createComment("[testing](http://kohsuse.org/)");
         try {
             assertThat(c.getPath(), nullValue());
@@ -554,6 +566,13 @@ public void testCreateCommitComment() throws Exception {
 
             c.update("updated text");
             assertThat(c.getBody(), equalTo("updated text"));
+
+            commit = gitHub.getUser("kohsuke")
+                    .getRepository("sandbox-ant")
+                    .getCommit("8ae38db0ea5837313ab5f39d43a6f73de3bd9000");
+
+            assertThat(commit.getCommitShortInfo().getCommentCount(), equalTo(31));
+
         } finally {
             c.delete();
         }

src/test/java/org/kohsuke/github/CommitTest.java

@@ -44,9 +44,11 @@ public void testQueryCommits() throws Exception {
                 .list()
                 .toList();
 
-        assertThat(commits.get(0).getSHA1(), equalTo("1cccddb22e305397151b2b7b87b4b47d74ca337b"));
         assertThat(commits.size(), equalTo(29));
 
+        GHCommit commit = commits.get(0);
+        assertThat(commit.getSHA1(), equalTo("1cccddb22e305397151b2b7b87b4b47d74ca337b"));
+
         commits = gitHub.getUser("jenkinsci")
                 .getRepository("jenkins")
                 .queryCommits()

src/test/java/org/kohsuke/github/GHRepositoryTest.java

@@ -411,6 +411,10 @@ public void listCommitCommentsNoComments() throws IOException {
                 .toList();
 
         assertThat("Commit has no comments", commitComments.isEmpty());
+
+        commitComments = getRepository().getCommit("c413fc1e3057332b93850ea48202627d29a37de5").listComments().toList();
+
+        assertThat("Commit has no comments", commitComments.isEmpty());
     }
 
     @Test
@@ -423,6 +427,14 @@ public void listCommitCommentsSomeComments() throws IOException {
         assertThat("Comment text found",
                 commitComments.stream().map(GHCommitComment::getBody).collect(Collectors.toList()),
                 containsInAnyOrder("comment 1", "comment 2"));
+
+        commitComments = getRepository().getCommit("499d91f9f846b0087b2a20cf3648b49dc9c2eeef").listComments().toList();
+
+        assertThat("Two comments present", commitComments.size(), equalTo(2));
+        assertThat("Comment text found",
+                commitComments.stream().map(GHCommitComment::getBody).collect(Collectors.toList()),
+                containsInAnyOrder("comment 1", "comment 2"));
+
     }
 
     @Test // Issue #261

src/test/resources/org/kohsuke/github/AppTest/wiremock/testCreateCommitComment/__files/repos_kohsuke_sandbox-ant-3.json

@@ -90,7 +90,7 @@
   "forks": 2,
   "open_issues": 0,
   "watchers": 2,
-  "default_branch": "main",
+  "default_branch": "master",
   "permissions": {
     "admin": false,
     "push": false,
@@ -189,7 +189,7 @@
     "forks": 4,
     "open_issues": 0,
     "watchers": 4,
-    "default_branch": "main"
+    "default_branch": "master"
   },
   "source": {
     "id": 3231216,
@@ -283,7 +283,7 @@
     "forks": 4,
     "open_issues": 0,
     "watchers": 4,
-    "default_branch": "main"
+    "default_branch": "master"
   },
   "network_count": 4,
   "subscribers_count": 0