Skip to content

Commit 87677f3

Browse files
committed
Ignore some missing methods and fields
1 parent 0668c5d commit 87677f3

File tree

4 files changed

+8
-32
lines changed

4 files changed

+8
-32
lines changed

pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,14 @@
545545
<excludes>
546546
<!-- Classes in internal are public but are considered private for API stability purposes -->
547547
<exclude>org.kohsuke.github.internal</exclude>
548+
<!-- Ignore protected items from Pagination update -->
549+
<exclude>org.kohsuke.github.PagedIterable#_iterator(int)</exclude>
550+
<exclude>org.kohsuke.github.PagedIterable#toArray(org.kohsuke.github.PagedIterator)</exclude>
551+
<exclude>org.kohsuke.github.PagedIterable#PagedIterable()</exclude>
552+
<exclude>org.kohsuke.github.PagedIterator#base</exclude>
553+
<exclude>org.kohsuke.github.PagedIterator#wrapUp(java.lang.Object[])</exclude>
554+
<exclude>org.kohsuke.github.PagedSearchIterable#_iterator(int)</exclude>
555+
<exclude>org.kohsuke.github.PagedSearchIterable#adapt(java.util.Iterator)</exclude>
548556
</excludes>
549557
</parameter>
550558
</configuration>

src/main/java/org/kohsuke/github/PagedIterable.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,13 @@ public class PagedIterable<T> implements Iterable<T> {
1818

1919
private final PaginatedEndpoint<?, T> paginatedEndpoint;
2020

21-
@Deprecated
22-
public PagedIterable() {
23-
this(null);
24-
}
25-
2621
/**
2722
* Instantiates a new git hub page contents iterable.
2823
*/
2924
PagedIterable(PaginatedEndpoint<?, T> paginatedEndpoint) {
3025
this.paginatedEndpoint = paginatedEndpoint;
3126
}
3227

33-
public PagedIterator<T> _iterator(int pageSize) {
34-
throw new RuntimeException("No longer used.");
35-
}
36-
3728
@Nonnull
3829
public final PagedIterator<T> iterator() {
3930
return new PagedIterator<>(paginatedEndpoint.items());
@@ -69,12 +60,6 @@ public PagedIterable<T> withPageSize(int size) {
6960
return this;
7061
}
7162

72-
@Nonnull
73-
@Deprecated
74-
protected T[] toArray(final PagedIterator<T> iterator) throws IOException {
75-
return paginatedEndpoint.toArray();
76-
}
77-
7863
GitHubResponse<T[]> toResponse() throws IOException {
7964
return paginatedEndpoint.toResponse();
8065
}

src/main/java/org/kohsuke/github/PagedIterator.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.kohsuke.github;
22

3-
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
4-
53
import java.util.Iterator;
64
import java.util.List;
75

@@ -23,10 +21,6 @@ public class PagedIterator<T> implements Iterator<T> {
2321

2422
private final PaginatedEndpointItems<T> endpointIterator;
2523

26-
@Deprecated
27-
@SuppressFBWarnings(value = { "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" }, justification = "No longer used")
28-
protected Iterator<T[]> base = null;
29-
3024
/**
3125
* Instantiates a new paged iterator.
3226
*
@@ -55,8 +49,4 @@ public T next() {
5549
public List<T> nextPage() {
5650
return endpointIterator.nextPage();
5751
}
58-
59-
@Deprecated
60-
protected void wrapUp(T[] page) {
61-
}
6252
}

src/main/java/org/kohsuke/github/PagedSearchIterable.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
44

5-
import java.util.Iterator;
6-
75
// TODO: Auto-generated Javadoc
86
/**
97
* {@link PagedIterable} enhanced to report search result specific information.
@@ -59,9 +57,4 @@ public boolean isIncomplete() {
5957
public PagedSearchIterable<T> withPageSize(int size) {
6058
return (PagedSearchIterable<T>) super.withPageSize(size);
6159
}
62-
63-
@Deprecated
64-
protected Iterator<T[]> adapt(final Iterator<? extends SearchResult<T>> base) {
65-
return null;
66-
}
6760
}

0 commit comments

Comments
 (0)