More coverage

Author: bitwiseman

src/main/java/org/kohsuke/github/GHCommitSearchBuilder.java

@@ -173,14 +173,7 @@ public GHCommitSearchBuilder is(String v) {
 
     @Override
     public PagedSearchIterable<GHCommit> list() {
-        return list(item -> {
-            String repoName = getRepoName(item.url);
-            try {
-                GHRepository repo = root().getRepository(repoName);
-                item.wrapUp(repo);
-            } catch (IOException ioe) {
-            }
-        });
+        return list(this::lateBindGHCommit);
     }
 
     /**
@@ -294,4 +287,16 @@ public GHCommitSearchBuilder user(String v) {
     protected String getApiUrl() {
         return "/search/commits";
     }
+
+    /**
+     * Exposed internally for testing only.
+     */
+    void lateBindGHCommit(GHCommit item) {
+        String repoName = getRepoName(item.getUrl().toString());
+        try {
+            GHRepository repo = root().getRepository(repoName);
+            item.wrapUp(repo);
+        } catch (IOException ioe) {
+        }
+    }
 }

src/main/java/org/kohsuke/github/PagedSearchIterable.java

@@ -60,14 +60,12 @@ public PagedSearchIterable<T> withPageSize(int size) {
     }
 
     @Override
-    PaginatedEndpointItems<? extends GitHubPage<T>, T> items() {
-        // TODO Auto-generated method stub
-        return super.items();
+    PaginatedEndpointItems<? extends SearchResult<T>, T> items() {
+        return new PaginatedEndpointItems<>(pages());
     }
 
     @Override
-    PaginatedEndpointPages<? extends GitHubPage<T>, T> pages() {
-        // TODO Auto-generated method stub
-        return super.pages();
+    PaginatedEndpointPages<? extends SearchResult<T>, T> pages() {
+        return searchPaginatedEndpoint.pages();
     }
 }

src/test/java/org/kohsuke/github/AppTest.java

@@ -432,6 +432,18 @@ public void testCommitSearch() throws IOException {
 
         GHCommit firstCommit = r.iterator().next();
         assertThat(firstCommit.listFiles().toList(), is(not(empty())));
+
+        GHCommitSearchBuilder builder = new GHCommitSearchBuilder(GitHub.offline());
+        GHException e = Assert.assertThrows(GHException.class, () -> builder.list().iterator().next());
+        assertThat(e.getMessage(), equalTo("Failed to retrieve https://api.github.invalid/search/commits?q="));
+
+        // Verify that this item initalizer does not throw when it otherwise would
+        builder.lateBindGHCommit(new GHCommit() {
+            @Override
+            public URL getUrl() {
+                return firstCommit.getUrl();
+            }
+        });
     }
 
     /**

src/test/java/org/kohsuke/github/PaginatedEndpointTest.java

@@ -65,6 +65,31 @@ public void testDeprecatedNextPage() throws IOException {
         assertThrows(NoSuchElementException.class, () -> items.nextPage());
     }
 
+    /**
+     * Test
+     *
+     * @throws IOException
+     *             Signals that an I/O exception has occurred.
+     */
+    @Test
+    public void testIterators() throws IOException {
+        var page = new GitHubPageArrayAdapter<>(new Object[]{ 1, 2, 3 });
+
+        var endpoint = PaginatedEndpoint.fromSinglePage(page, Object.class);
+
+        var iterator = endpoint.iterator();
+        assertThat(iterator.next(), equalTo(1));
+        assertThat(iterator.next(), equalTo(2));
+        assertThat(iterator.next(), equalTo(3));
+        assertThat(iterator.hasNext(), equalTo(false));
+
+        var pagedIterator = new PagedIterator<>(endpoint.items());
+        assertThat(pagedIterator.next(), equalTo(1));
+        var nextPage = pagedIterator.nextPage();
+        assertThat(nextPage.size(), equalTo(2));
+        assertThat(iterator.hasNext(), equalTo(false));
+    }
+
     /**
      * Test
      *