Followup cleanup based on root streamlining

Author: bitwiseman

src/main/java/org/kohsuke/github/GHApp.java

@@ -183,10 +183,6 @@ public void setPermissions(Map<String, String> permissions) {
         throw new RuntimeException("Do not use this method.");
     }
 
-    GHApp wrapUp(GitHub root) {
-        return this;
-    }
-
     /**
      * Obtains all the installations associated with this app.
      * <p>
@@ -200,7 +196,7 @@ public PagedIterable<GHAppInstallation> listInstallations() {
         return root().createRequest()
                 .withPreview(MACHINE_MAN)
                 .withUrlPath("/app/installations")
-                .toIterable(GHAppInstallation[].class, item -> item.wrapUp(root()));
+                .toIterable(GHAppInstallation[].class, null);
     }
 
     /**
@@ -220,8 +216,7 @@ public GHAppInstallation getInstallationById(long id) throws IOException {
         return root().createRequest()
                 .withPreview(MACHINE_MAN)
                 .withUrlPath(String.format("/app/installations/%d", id))
-                .fetch(GHAppInstallation.class)
-                .wrapUp(root());
+                .fetch(GHAppInstallation.class);
     }
 
     /**
@@ -242,8 +237,7 @@ public GHAppInstallation getInstallationByOrganization(String name) throws IOExc
         return root().createRequest()
                 .withPreview(MACHINE_MAN)
                 .withUrlPath(String.format("/orgs/%s/installation", name))
-                .fetch(GHAppInstallation.class)
-                .wrapUp(root());
+                .fetch(GHAppInstallation.class);
     }
 
     /**
@@ -266,8 +260,7 @@ public GHAppInstallation getInstallationByRepository(String ownerName, String re
         return root().createRequest()
                 .withPreview(MACHINE_MAN)
                 .withUrlPath(String.format("/repos/%s/%s/installation", ownerName, repositoryName))
-                .fetch(GHAppInstallation.class)
-                .wrapUp(root());
+                .fetch(GHAppInstallation.class);
     }
 
     /**
@@ -287,8 +280,7 @@ public GHAppInstallation getInstallationByUser(String name) throws IOException {
         return root().createRequest()
                 .withPreview(MACHINE_MAN)
                 .withUrlPath(String.format("/users/%s/installation", name))
-                .fetch(GHAppInstallation.class)
-                .wrapUp(root());
+                .fetch(GHAppInstallation.class);
     }
 
 }

src/main/java/org/kohsuke/github/GHAppCreateTokenBuilder.java

@@ -78,8 +78,7 @@ public GHAppInstallationToken create() throws IOException {
         return builder.method("POST")
                 .withPreview(MACHINE_MAN)
                 .withUrlPath(apiUrlTail)
-                .fetch(GHAppInstallationToken.class)
-                .wrapUp(root());
+                .fetch(GHAppInstallationToken.class);
     }
 
 }

src/main/java/org/kohsuke/github/GHAppInstallation.java

@@ -137,8 +137,8 @@ private static class GHAppInstallationRepositoryResult extends SearchResult<GHRe
 
         @Override
         GHRepository[] getItems(GitHub root) {
-            for (GHRepository item : repositories)
-                item.wrap(root);
+            for (GHRepository item : repositories) {
+            }
             return repositories;
         }
     }
@@ -304,10 +304,6 @@ public void setRepositorySelection(GHRepositorySelection repositorySelection) {
         throw new RuntimeException("Do not use this method.");
     }
 
-    GHAppInstallation wrapUp(GitHub root) {
-        return this;
-    }
-
     /**
      * Delete a Github App installation
      * <p>

src/main/java/org/kohsuke/github/GHAppInstallationToken.java

@@ -131,8 +131,4 @@ public Date getExpiresAt() throws IOException {
     private Object expiresAtStr(Date id, Class type) {
         return expires_at;
     }
-
-    GHAppInstallationToken wrapUp(GitHub root) {
-        return this;
-    }
 }

src/main/java/org/kohsuke/github/GHArtifact.java

@@ -130,12 +130,8 @@ private String getApiRoute() {
 
     GHArtifact wrapUp(GHRepository owner) {
         this.owner = owner;
-        return wrapUp(owner.root());
-    }
-
-    GHArtifact wrapUp(GitHub root) {
-        if (owner != null)
-            owner.wrap(root);
+        this.owner = owner;
         return this;
     }
+
 }

src/main/java/org/kohsuke/github/GHAsset.java

@@ -147,7 +147,6 @@ private String getApiRoute() {
 
     GHAsset wrap(GHRelease release) {
         this.owner = release.getOwner();
-        owner.root();
         return this;
     }
 

src/main/java/org/kohsuke/github/GHAuthorization.java

@@ -146,10 +146,6 @@ public String getFingerprint() {
         return fingerprint;
     }
 
-    GHAuthorization wrap(GitHub root) {
-        return this;
-    }
-
     @SuppressFBWarnings(value = { "UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD", "UWF_UNWRITTEN_FIELD" },
             justification = "JSON API")
     private static class App {

src/main/java/org/kohsuke/github/GHBranch.java

@@ -97,8 +97,7 @@ public GHBranchProtection getProtection() throws IOException {
         return root().createRequest()
                 .withPreview(Previews.LUKE_CAGE)
                 .setRawUrlPath(protection_url)
-                .fetch(GHBranchProtection.class)
-                .wrap(this);
+                .fetch(GHBranchProtection.class);
     }
 
     /**
@@ -222,7 +221,6 @@ public String toString() {
 
     GHBranch wrap(GHRepository repo) {
         this.owner = repo;
-        repo.root();
         return this;
     }
 }

src/main/java/org/kohsuke/github/GHBranchProtection.java

@@ -115,11 +115,6 @@ public String getUrl() {
         return url;
     }
 
-    GHBranchProtection wrap(GHBranch branch) {
-        branch.root();
-        return this;
-    }
-
     private Requester requester() {
         return root().createRequest().withPreview(ZZZAX);
     }

src/main/java/org/kohsuke/github/GHBranchProtectionBuilder.java

@@ -94,8 +94,7 @@ public GHBranchProtection enable() throws IOException {
                 .withNullable("restrictions", restrictions)
                 .withNullable("enforce_admins", enforceAdmins)
                 .withUrlPath(branch.getProtectionUrl().toString())
-                .fetch(GHBranchProtection.class)
-                .wrap(branch);
+                .fetch(GHBranchProtection.class);
     }
 
     /**