From fa6b949200513c258643991845de48be37f5e2b5 Mon Sep 17 00:00:00 2001 From: Liam Newman Date: Fri, 28 Feb 2025 15:37:31 -0800 Subject: [PATCH 1/2] Revert removal of getPullRequests Method was not marked as deprecated, but was removed. Adding it back to prevent breaks. Fixes #1957 --- .../java/org/kohsuke/github/GHRepository.java | 16 ++++++++++++++++ .../org/kohsuke/github/GHPullRequestTest.java | 4 +--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/kohsuke/github/GHRepository.java b/src/main/java/org/kohsuke/github/GHRepository.java index 2916d8fac5..ce4df10184 100644 --- a/src/main/java/org/kohsuke/github/GHRepository.java +++ b/src/main/java/org/kohsuke/github/GHRepository.java @@ -1510,6 +1510,22 @@ public GHPullRequest getPullRequest(int i) throws IOException { return root().createRequest().withUrlPath(getApiTailUrl("pulls/" + i)).fetch(GHPullRequest.class).wrapUp(this); } + /** + * Retrieves all the pull requests of a particular state. + * + * @param state + * the state + * @return the pull requests + * @throws IOException + * the io exception + * @see #listPullRequests(GHIssueState) #listPullRequests(GHIssueState) + * @deprecated Use {@link #queryPullRequests()} + */ + @Deprecated + public List getPullRequests(GHIssueState state) throws IOException { + return queryPullRequests().state(state).list().toList(); + } + /** * Retrieves pull requests. * diff --git a/src/test/java/org/kohsuke/github/GHPullRequestTest.java b/src/test/java/org/kohsuke/github/GHPullRequestTest.java index 0a2e4a2712..59a19c82f2 100644 --- a/src/test/java/org/kohsuke/github/GHPullRequestTest.java +++ b/src/test/java/org/kohsuke/github/GHPullRequestTest.java @@ -918,9 +918,7 @@ public void getUserTest() throws IOException { prSingle.getMergeable(); assertThat(prSingle.getUser().root(), notNullValue()); - PagedIterable ghPullRequests = getRepository().queryPullRequests() - .state(GHIssueState.OPEN) - .list(); + List ghPullRequests = getRepository().getPullRequests(GHIssueState.OPEN); for (GHPullRequest pr : ghPullRequests) { assertThat(pr.getUser().root(), notNullValue()); pr.getMergeable(); From 57156ce5c27b9ac805abfc8bbf440ccf942edadd Mon Sep 17 00:00:00 2001 From: Liam Newman Date: Tue, 18 Mar 2025 12:44:32 -0700 Subject: [PATCH 2/2] Update src/main/java/org/kohsuke/github/GHRepository.java --- src/main/java/org/kohsuke/github/GHRepository.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GHRepository.java b/src/main/java/org/kohsuke/github/GHRepository.java index 4fb7fffd59..24807890f0 100644 --- a/src/main/java/org/kohsuke/github/GHRepository.java +++ b/src/main/java/org/kohsuke/github/GHRepository.java @@ -1511,7 +1511,6 @@ public GHPullRequest getPullRequest(int number) throws IOException { * @return the pull requests * @throws IOException * the io exception - * @see #listPullRequests(GHIssueState) #listPullRequests(GHIssueState) * @deprecated Use {@link #queryPullRequests()} */ @Deprecated