Skip to content

Commit 20b29c3

Browse files
authored
Merge pull request #938 from hubmapconsortium/yuanzhou/large-payload-files
Fix index out of range in validation and use const
2 parents de76c6e + bb60eaf commit 20b29c3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/schema/schema_manager.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ def get_all_fields_to_exclude_from_query_string(request):
398398
second_level_list = []
399399

400400
for item in all_properties_to_exclude:
401-
if item in prohibited_properties or item.split('.')[1] in prohibited_properties:
401+
if item in prohibited_properties or ('.' in item and item.split('.')[1] in prohibited_properties):
402402
raise ValueError(f"Entity property '{item}' is not allowed in the 'exclude' query parameter.")
403403

404404
return all_properties_to_exclude
@@ -490,7 +490,7 @@ def determine_property_exclusion_type(normalized_entity_type, flat_list):
490490
# Only care about the properties defined in schema yaml
491491
for item in top_level_list:
492492
if item in properties:
493-
if 'on_read_trigger' in properties[item]:
493+
if TriggerTypeEnum.ON_READ in properties[item]:
494494
triggered_top_properties_to_skip.append(item)
495495
else:
496496
neo4j_top_properties_to_skip.append(item)
@@ -500,7 +500,7 @@ def determine_property_exclusion_type(normalized_entity_type, flat_list):
500500
for item in second_level_list:
501501
prefix = item.split('.')[0]
502502
if prefix in properties:
503-
if 'on_read_trigger' in properties[prefix]:
503+
if TriggerTypeEnum.ON_READ in properties[prefix]:
504504
triggered_top_properties_to_skip.append(item)
505505
else:
506506
neo4j_nested_properties_to_skip.append(item)

0 commit comments

Comments
 (0)