Skip to content

Commit 3f7dc9c

Browse files
committed
Logging tweaks
1 parent 53f2778 commit 3f7dc9c

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

src/schema/schema_manager.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,9 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
418418
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
419419

420420
if 'uuid' in existing_data_dict:
421-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class} {existing_data_dict['uuid']}")
421+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
422422
else:
423-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
423+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
424424

425425
# No return values for 'after_create_trigger' and 'after_update_trigger'
426426
# because the property value is already set and stored in neo4j
@@ -445,9 +445,9 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
445445
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
446446

447447
if 'uuid' in existing_data_dict:
448-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class} {existing_data_dict['uuid']}")
448+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
449449
else:
450-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
450+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
451451

452452
# Will set the trigger return value as the property value by default
453453
# Unless the return value is to be assigned to another property different target key
@@ -495,9 +495,9 @@ def generate_triggered_data(trigger_type: TriggerTypeEnum, normalized_class, req
495495
trigger_method_to_call = getattr(schema_triggers, trigger_method_name)
496496

497497
if 'uuid' in existing_data_dict:
498-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class} {existing_data_dict['uuid']}")
498+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class} {existing_data_dict['uuid']}")
499499
else:
500-
logger.info(f"To run {trigger_type.value}: {trigger_method_name} defined for {normalized_class}")
500+
logger.info(f"To run {trigger_type.value}: {trigger_method_name} for {normalized_class}")
501501

502502
# Will set the trigger return value as the property value by default
503503
# Unless the return value is to be assigned to another property different target key
@@ -1041,8 +1041,11 @@ def execute_entity_level_validator(validator_type, normalized_entity_type, reque
10411041
try:
10421042
# Get the target validator method defined in the schema_validators.py module
10431043
validator_method_to_call = getattr(schema_validators, validator_method_name)
1044-
1045-
logger.info(f"To run {validator_type}: {validator_method_name} defined for entity {normalized_entity_type}")
1044+
1045+
if 'uuid' in existing_entity_dict:
1046+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} {existing_entity_dict['uuid']}")
1047+
else:
1048+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type}")
10461049

10471050
# Create a dictionary to hold data need by any entity validator, which must be populated
10481051
# with validator specific requirements when the method to be called is determined.
@@ -1062,7 +1065,7 @@ def execute_entity_level_validator(validator_type, normalized_entity_type, reque
10621065
except schema_errors.LockedEntityUpdateException as leue:
10631066
raise leue
10641067
except Exception as e:
1065-
msg = f"Failed to call the {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type}"
1068+
msg = f"Failed to call the {validator_type} method: {validator_method_name} for {normalized_entity_type}"
10661069
# Log the full stack trace, prepend a line with our message
10671070
logger.exception(msg)
10681071
raise e
@@ -1107,7 +1110,10 @@ def execute_property_level_validators(validator_type, normalized_entity_type, re
11071110
# Get the target validator method defined in the schema_validators.py module
11081111
validator_method_to_call = getattr(schema_validators, validator_method_name)
11091112

1110-
logger.info(f"To run {validator_type}: {validator_method_name} defined for entity {normalized_entity_type} on property {key}")
1113+
if 'uuid' in existing_data_dict:
1114+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} {existing_data_dict['uuid']} on property {key}")
1115+
else:
1116+
logger.info(f"To run {validator_type}: {validator_method_name} for {normalized_entity_type} on property {key}")
11111117

11121118
validator_method_to_call(key, normalized_entity_type, request, existing_data_dict, new_data_dict)
11131119
except schema_errors.MissingApplicationHeaderException as e:
@@ -1117,12 +1123,12 @@ def execute_property_level_validators(validator_type, normalized_entity_type, re
11171123
except ValueError as ve:
11181124
raise ValueError(ve)
11191125
except schema_errors.UnimplementedValidatorException as uve:
1120-
msg = f"Failed to call the {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type} on property {key}"
1126+
msg = f"Failed to call the {validator_type} method: {validator_method_name} for {normalized_entity_type} on property {key}"
11211127
# Log the full stack trace, prepend a line with our message
11221128
logger.exception(f"{msg}. {str(uve)}")
11231129
raise uve
11241130
except Exception as e:
1125-
msg = f"Unexpected exception calling {validator_type} method: {validator_method_name} defined for entity {normalized_entity_type} on property {key}"
1131+
msg = f"Unexpected exception calling {validator_type} method: {validator_method_name} for {normalized_entity_type} on property {key}"
11261132
# Log the full stack trace, prepend a line with our message
11271133
logger.exception(f"{msg}. {str(e)}")
11281134
raise e

0 commit comments

Comments
 (0)