From 6d4dc4843599fdf1f6c5c5013f111d36bb8d0557 Mon Sep 17 00:00:00 2001
From: kburke <209327+kburke@users.noreply.github.com>
Date: Fri, 4 Apr 2025 15:29:13 -0400
Subject: [PATCH] Code review request - revised error message when updates
 locked out for entity.

---
 src/schema/schema_validators.py | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/schema/schema_validators.py b/src/schema/schema_validators.py
index 75b96b5c..a3c56492 100644
--- a/src/schema/schema_validators.py
+++ b/src/schema/schema_validators.py
@@ -925,20 +925,16 @@ def _is_entity_locked_against_update(existing_entity_dict):
     entity_type = existing_entity_dict['entity_type']
     if entity_type in ['Publication','Dataset']:
         if 'status' in existing_entity_dict and existing_entity_dict['status'] == 'Published':
-            raise schema_errors.LockedEntityUpdateException(f"{entity_type} cannot be modified, due to"
-                                                            f" status={existing_entity_dict['status']}.")
+            raise schema_errors.LockedEntityUpdateException(f"Permission denied to change a published/public {entity_type}.")
     elif entity_type in ['Donor','Sample']:
         if 'data_access_level' in existing_entity_dict and existing_entity_dict['data_access_level'] == 'public':
-            raise schema_errors.LockedEntityUpdateException(f"{entity_type} cannot be modified, due to"
-                                                            f" data_access_level={existing_entity_dict['data_access_level']}.")
+            raise schema_errors.LockedEntityUpdateException(f"Permission denied to change a published/public {entity_type}.")
     elif entity_type in ['Collection','Epicollection']:
         if 'doi_url' in existing_entity_dict and existing_entity_dict['doi_url']:
-            raise schema_errors.LockedEntityUpdateException(f"{entity_type} cannot be modified, due to"
-                                                            f" doi_url={existing_entity_dict['doi_url']}.")
+            raise schema_errors.LockedEntityUpdateException(f"Permission denied to change a published/public {entity_type}.")
         # Probably never get here, since doi_url and registered_doi must be set as a pair.
         if 'registered_doi' in existing_entity_dict and existing_entity_dict['registered_doi']:
-            raise schema_errors.LockedEntityUpdateException(f"{entity_type} cannot be modified, due to"
-                                                            f" registered_doi={existing_entity_dict['registered_doi']}.")
+            raise schema_errors.LockedEntityUpdateException(f"Permission denied to change a published/public {entity_type}.")
     else:
         entity_uuid = existing_entity_dict['uuid']
         raise schema_errors.LockedEntityUpdateException(f'Unable to check if {entity_type} for {entity_uuid} is locked!')