Merge pull request #936 from hubmapconsortium/lchoy/fix-sample-index-metadata-error

Check for existence of metadata field and ensure the value is not None

Author: yuanzhou

.travis.yml

@@ -5,10 +5,6 @@ git:
 language: python
 python:
   - "3.9"
-services:
-  - elasticsearch
-before_script:
-  - sleep 10  # Advised by https://docs.travis-ci.com/user/database-setup/#elasticsearch
 
 # Uncomment when test against a commons github branch
 # also need to enable the branch github install in requirements.txt

src/hubmap_translation/addl_index_transformations/portal/__init__.py

@@ -126,7 +126,7 @@ def _simple_clean(doc):
         doc[name_field] = doc[name_field].title()
 
     # Clean up metadata:
-    if 'metadata' in doc:
+    if doc.get('metadata') is not None:
         metadata = doc['metadata']
 
         bad_fields = [