Merge pull request #39 from hubmapconsortium/release-please--branches--main--changes--next

release: 1.0.0-alpha.18

Author: yuanzhou

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.0.0-alpha.17"
+  ".": "1.0.0-alpha.18"
 }

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 1.0.0-alpha.18 (2025-07-12)
+
+Full Changelog: [v1.0.0-alpha.17...v1.0.0-alpha.18](https://github.com/hubmapconsortium/search-python-sdk/compare/v1.0.0-alpha.17...v1.0.0-alpha.18)
+
+### Bug Fixes
+
+* **client:** don't send Content-Type header on GET requests ([1898678](https://github.com/hubmapconsortium/search-python-sdk/commit/18986789c246be8b94a66875b68cf47af0c774c0))
+
 ## 1.0.0-alpha.17 (2025-07-11)
 
 Full Changelog: [v1.0.0-alpha.16...v1.0.0-alpha.17](https://github.com/hubmapconsortium/search-python-sdk/compare/v1.0.0-alpha.16...v1.0.0-alpha.17)

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "hubmap_search_sdk"
-version = "1.0.0-alpha.17"
+version = "1.0.0-alpha.18"
 description = "The official Python library for the hubmap-search-sdk API"
 dynamic = ["readme"]
 license = "MIT"
@@ -39,7 +39,7 @@ Homepage = "https://github.com/hubmapconsortium/search-python-sdk"
 Repository = "https://github.com/hubmapconsortium/search-python-sdk"
 
 [project.optional-dependencies]
-aiohttp = ["aiohttp", "httpx_aiohttp>=0.1.6"]
+aiohttp = ["aiohttp", "httpx_aiohttp>=0.1.8"]
 
 [tool.rye]
 managed = true

src/hubmap_search_sdk/_base_client.py

@@ -532,6 +532,15 @@ def _build_request(
             # work around https://github.com/encode/httpx/discussions/2880
             kwargs["extensions"] = {"sni_hostname": prepared_url.host.replace("_", "-")}
 
+        is_body_allowed = options.method.lower() != "get"
+
+        if is_body_allowed:
+            kwargs["json"] = json_data if is_given(json_data) else None
+            kwargs["files"] = files
+        else:
+            headers.pop("Content-Type", None)
+            kwargs.pop("data", None)
+
         # TODO: report this error to httpx
         return self._client.build_request(  # pyright: ignore[reportUnknownMemberType]
             headers=headers,
@@ -543,8 +552,6 @@ def _build_request(
             # so that passing a `TypedDict` doesn't cause an error.
             # https://github.com/microsoft/pyright/issues/3526#event-6715453066
             params=self.qs.stringify(cast(Mapping[str, Any], params)) if params else None,
-            json=json_data if is_given(json_data) else None,
-            files=files,
             **kwargs,
         )
 

src/hubmap_search_sdk/_version.py

@@ -1,4 +1,4 @@
 # File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.
 
 __title__ = "hubmap_search_sdk"
-__version__ = "1.0.0-alpha.17"  # x-release-please-version
+__version__ = "1.0.0-alpha.18"  # x-release-please-version

tests/test_client.py

@@ -472,7 +472,7 @@ def test_request_extra_query(self) -> None:
     def test_multipart_repeating_array(self, client: HubmapSearchSDK) -> None:
         request = client._build_request(
             FinalRequestOptions.construct(
-                method="get",
+                method="post",
                 url="/foo",
                 headers={"Content-Type": "multipart/form-data; boundary=6b7ba517decee4a450543ea6ae821c82"},
                 json_data={"array": ["foo", "bar"]},
@@ -1300,7 +1300,7 @@ def test_request_extra_query(self) -> None:
     def test_multipart_repeating_array(self, async_client: AsyncHubmapSearchSDK) -> None:
         request = async_client._build_request(
             FinalRequestOptions.construct(
-                method="get",
+                method="post",
                 url="/foo",
                 headers={"Content-Type": "multipart/form-data; boundary=6b7ba517decee4a450543ea6ae821c82"},
                 json_data={"array": ["foo", "bar"]},