fix: remove mockery due to security vulnerability alert (#79)

Author: joeyguerra

package-lock.json

@@ -33,7 +33,6 @@
     "chai": "^4.3.7",
     "matchdep": "^2.0.0",
     "mocha": "^10.2.0",
-    "mockery": "^2.1.0",
     "nyc": "^15.1.0",
     "semantic-release": "^21.0.2",
     "sinon": "^15.0.4",

package.json

@@ -0,0 +1,19 @@
+const Module = require('module')
+const originalRequire = Module.prototype.require
+const hookModuleToReturnMockFromRequire = (module, mock) => {
+  Module.prototype.require = function () {
+    if (arguments[0] === module) {
+      return mock
+    }
+    return originalRequire.apply(this, arguments)
+  }
+}
+
+const resetModuleMocks = () => {
+  Module.prototype.require = originalRequire
+}
+
+module.exports = {
+  hook: hookModuleToReturnMockFromRequire,
+  reset: resetModuleMocks
+}

test/fixtures/RequireMocker.js

@@ -6,7 +6,7 @@ const path = require('path')
 
 const chai = require('chai')
 const expect = chai.expect
-const mockery = require('mockery')
+const { hook, reset } = require('./fixtures/RequireMocker.js')
 
 chai.use(require('sinon-chai'))
 
@@ -31,19 +31,15 @@ const newTestRobot = function newTestRobot () {
 
 describe('help in private', () => describe('message visibility', () => {
   beforeEach(function () {
-    mockery.enable({
-      warnOnReplace: false,
-      warnOnUnregistered: false
-    })
-    mockery.registerMock('hubot-mock-adapter', require('./fixtures/MockAdapter.js'))
+    hook('hubot-mock-adapter', require('./fixtures/MockAdapter.js'))
     this.robot = newTestRobot()
     this.robot.run()
     this.user = this.robot.brain.userForName('john')
   })
 
   afterEach(function () {
     this.robot.shutdown()
-    mockery.disable()
+    reset()
   })
 
   context('when HUBOT_HELP_REPLY_IN_PRIVATE is unset', () => it('replies in the same room', function (done) {

test/help_message_visibility_test.js

@@ -6,7 +6,7 @@ const path = require('path')
 
 const chai = require('chai')
 const expect = chai.expect
-const mockery = require('mockery')
+const { hook, reset } = require('./fixtures/RequireMocker.js')
 
 chai.use(require('sinon-chai'))
 
@@ -30,19 +30,15 @@ const newTestRobot = function newTestRobot () {
 
 describe('help', () => describe('getHelpCommands', () => {
   beforeEach(function () {
-    mockery.enable({
-      warnOnReplace: false,
-      warnOnUnregistered: false
-    })
-    mockery.registerMock('hubot-mock-adapter', require('./fixtures/MockAdapter.js'))
+    hook('hubot-mock-adapter', require('./fixtures/MockAdapter.js'))
     this.robot = newTestRobot()
     this.robot.run()
     this.user = this.robot.brain.userForName('john')
   })
 
   afterEach(function () {
     this.robot.shutdown()
-    mockery.disable()
+    reset()
   })
 
   context('when HUBOT_HELP_HIDDEN_COMMANDS is not set', () => it('lists all commands', function (done) {