Skip to content

Commit 38e3a26

Browse files
sobolevnnoahbkim
authored andcommitted
pythongh-121571: Do not use EnvironmentError in tests, use OSError instead (python#121572)
1 parent 81c3131 commit 38e3a26

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Lib/test/support/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ def skip_if_buildbot(reason=None):
387387
reason = 'not suitable for buildbots'
388388
try:
389389
isbuildbot = getpass.getuser().lower() == 'buildbot'
390-
except (KeyError, EnvironmentError) as err:
390+
except (KeyError, OSError) as err:
391391
warnings.warn(f'getpass.getuser() failed {err}.', RuntimeWarning)
392392
isbuildbot = False
393393
return unittest.skipIf(isbuildbot, reason)

Lib/test/test_subprocess.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1407,7 +1407,7 @@ def open_fds():
14071407
t = threading.Thread(target=open_fds)
14081408
t.start()
14091409
try:
1410-
with self.assertRaises(EnvironmentError):
1410+
with self.assertRaises(OSError):
14111411
subprocess.Popen(NONEXISTING_CMD,
14121412
stdin=subprocess.PIPE,
14131413
stdout=subprocess.PIPE,

0 commit comments

Comments
 (0)