Skip to content

Commit 2dc96fd

Browse files
author
Edvard Majakari
committed
Refactor: guarantee self.map_params is always present
Removes unnecessary if conditions; just call _rewrite_params any time it is required
1 parent b32b84b commit 2dc96fd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

hug/interface.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ def __init__(self, route, function):
212212
for name, transform in self.interface.input_transformations.items()
213213
}
214214
else:
215+
self.map_params = {}
215216
self.input_transformations = self.interface.input_transformations
216217

217218
if "output" in route:
@@ -417,8 +418,7 @@ def __call__(self, *args, **kwargs):
417418
self.api.delete_context(context, errors=errors)
418419
return outputs(errors) if outputs else errors
419420

420-
if getattr(self, "map_params", None):
421-
self._rewrite_params(kwargs)
421+
self._rewrite_params(kwargs)
422422
try:
423423
result = self.interface(**kwargs)
424424
if self.transform:
@@ -617,8 +617,7 @@ def exit_callback(message):
617617
elif add_options_to:
618618
pass_to_function[add_options_to].append(option)
619619

620-
if getattr(self, "map_params", None):
621-
self._rewrite_params(pass_to_function)
620+
self._rewrite_params(pass_to_function)
622621

623622
try:
624623
if args:
@@ -816,8 +815,7 @@ def call_function(self, parameters):
816815
parameters = {
817816
key: value for key, value in parameters.items() if key in self.all_parameters
818817
}
819-
if getattr(self, "map_params", None):
820-
self._rewrite_params(parameters)
818+
self._rewrite_params(parameters)
821819

822820
return self.interface(**parameters)
823821

0 commit comments

Comments
 (0)