Skip to content

Commit fd408e1

Browse files
Merge pull request #853 from pnijhara/pnijhara-patch-1
Fix some code quality and bug-risk issues
2 parents bde32a1 + 0e4aa4c commit fd408e1

File tree

3 files changed

+19
-6
lines changed

3 files changed

+19
-6
lines changed

.deepsource.toml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
version = 1
2+
3+
test_patterns = ["tests/**"]
4+
5+
exclude_patterns = [
6+
"examples/**",
7+
"benchmarks/**"
8+
]
9+
10+
[[analyzers]]
11+
name = "python"
12+
enabled = true
13+
14+
[analyzers.meta]
15+
runtime_version = "3.x.x"

hug/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def add_exception_handler(self, exception_type, error_handler, versions=(None,))
173173

174174
for version in versions:
175175
placement = self._exception_handlers.setdefault(version, OrderedDict())
176-
placement[exception_type] = (error_handler,) + placement.get(exception_type, tuple())
176+
placement[exception_type] = (error_handler,) + placement.get(exception_type, ())
177177

178178
def extend(self, http_api, route="", base_url="", **kwargs):
179179
"""Adds handlers from a different Hug API to this one - to create a single API"""

hug/interface.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def __init__(self, route, function):
186186
self.parameters = tuple(route["parameters"])
187187
self.all_parameters = set(route["parameters"])
188188
self.required = tuple(
189-
[parameter for parameter in self.parameters if parameter not in self.defaults]
189+
parameter for parameter in self.parameters if parameter not in self.defaults
190190
)
191191

192192
if "map_params" in route:
@@ -204,10 +204,8 @@ def __init__(self, route, function):
204204
self.all_parameters.add(interface_name)
205205
if internal_name in self.required:
206206
self.required = tuple(
207-
[
208-
interface_name if param == internal_name else param
209-
for param in self.required
210-
]
207+
interface_name if param == internal_name else param
208+
for param in self.required
211209
)
212210

213211
reverse_mapping = {

0 commit comments

Comments
 (0)