Skip to content
This repository was archived by the owner on Dec 28, 2025. It is now read-only.

Commit 86c8450

Browse files
mengxpgogogo-engmengxpdavidzollodybyte
authored
[Improve][Connector] Replace printStackTrace with proper logging (apache#10176)
Co-authored-by: mengxp <mengxp@longjitech.com> Co-authored-by: David Zollo <davidzollo365@gmail.com> Co-authored-by: dy102 <132787602+dybyte@users.noreply.github.com>
1 parent aeed71c commit 86c8450

File tree

3 files changed

+9
-8
lines changed
  • seatunnel-connectors-v2
    • connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client
    • connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader
    • connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink

3 files changed

+9
-8
lines changed

seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,11 @@ public ActivemqClient(ReadonlyConfig config) {
6363
log.info("connection created");
6464

6565
} catch (Exception e) {
66-
e.printStackTrace();
66+
log.error("Error while creating AMQ client", e);
6767
throw new ActivemqConnectorException(
6868
ActivemqConnectorErrorCode.CREATE_ACTIVEMQ_CLIENT_FAILED,
69-
"Error while create AMQ client ");
69+
"Error while create AMQ client ",
70+
e);
7071
}
7172
}
7273

seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ public void onClosing(@NotNull WebSocket webSocket, int code, @NotNull String re
9898
@Override
9999
public void onFailure(
100100
@NotNull WebSocket webSocket, @NotNull Throwable t, @Nullable Response response) {
101-
log.error("WebSocket connection failed: " + t.getMessage());
102-
t.printStackTrace();
101+
log.error("WebSocket connection failed", t);
103102
scheduleReconnect();
104103
}
105104

@@ -108,7 +107,8 @@ public void onMessage(@NotNull WebSocket webSocket, @NotNull String text) {
108107
try {
109108
buffer.put(text);
110109
} catch (InterruptedException e) {
111-
e.printStackTrace();
110+
log.error("Failed to put message into buffer", e);
111+
Thread.currentThread().interrupt();
112112
}
113113
}
114114

@@ -139,7 +139,8 @@ private void scheduleReconnect() {
139139
Thread.sleep(RETRY_DELAY_MS);
140140
connect();
141141
} catch (InterruptedException e) {
142-
e.printStackTrace();
142+
log.error("Reconnection attempt interrupted", e);
143+
Thread.currentThread().interrupt();
143144
}
144145
})
145146
.start();

seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ public void write(SeaTunnelRow element) throws IOException {
7777
try {
7878
this.client.PutLogs(plr);
7979
} catch (Throwable e) {
80-
log.error("write logs failed", e);
81-
e.printStackTrace();
80+
log.error("Failed to write logs to SLS", e);
8281
throw new IOException(e);
8382
}
8483
}

0 commit comments

Comments
 (0)