Add tests to ensure that /tmp volume mount works

Author: alvarobartt

.github/workflows/run-tests-action.yml

@@ -45,6 +45,20 @@ jobs:
           uv venv --python 3.10
           uv pip install -r tests/requirements.txt
 
+      - name: Check Docker can write on /tmp
+        run: |
+          docker run --rm \
+            -v /tmp/test-volume:/app/data \
+            alpine:latest \
+            /bin/sh -c "echo 'Hello from Docker!' > /app/data/test.txt"
+          if [ -f /tmp/test-volume/test.txt ]; then
+            echo "File exists in mounted volume"
+            cat /tmp/test-volume/test.txt
+          else
+            echo "File does not exist in mounted volume"
+            exit 1
+          fi
+
       - name: Run Hugging Face DLCs Tests
         run: uv run pytest -s tests/
         env:

tests/pytorch/training/test_trl.py

@@ -25,6 +25,10 @@ def test_trl(caplog: pytest.LogCaptureFixture, tmp_path: PosixPath) -> None:
     tmp_path.mkdir(exist_ok=True)
     tmp_path.chmod(0o775)
 
+    # Check that the Docker volume mount can write to the `tmp_path`
+    with open(tmp_path / "test.txt", "w") as f:
+        f.write("Hello, World!")
+
     logging.info("Running the container for TRL...")
     container = client.containers.run(
         os.getenv(
@@ -56,7 +60,7 @@ def test_trl(caplog: pytest.LogCaptureFixture, tmp_path: PosixPath) -> None:
         detach=True,
         # Mount the volume from the `tmp_path` to the `/opt/huggingface/trained_model`
         volumes={
-            f"{tmp_path}/": {
+            tmp_path: {
                 "bind": "/opt/huggingface/trained_model",
                 "mode": "rw",
             }
@@ -91,6 +95,10 @@ def test_trl_peft(caplog: pytest.LogCaptureFixture, tmp_path: PosixPath) -> None
     tmp_path.mkdir(exist_ok=True)
     tmp_path.chmod(0o775)
 
+    # Check that the Docker volume mount can write to the `tmp_path`
+    with open(tmp_path / "test.txt", "w") as f:
+        f.write("Hello, World!")
+
     logging.info("Running the container for TRL...")
     container = client.containers.run(
         os.getenv(
@@ -125,7 +133,7 @@ def test_trl_peft(caplog: pytest.LogCaptureFixture, tmp_path: PosixPath) -> None
         detach=True,
         # Mount the volume from the `tmp_path` to the `/opt/huggingface/trained_model`
         volumes={
-            f"{tmp_path}/": {
+            tmp_path: {
                 "bind": "/opt/huggingface/trained_model",
                 "mode": "rw",
             }