-
Notifications
You must be signed in to change notification settings - Fork 903
Feat/claude images mcp #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/claude images mcp #3029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot! mostly nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking lovely - it's mostly there imo, mostly think we should contextualise the HF MCP server and ZeroGPU a bit more and perhaps even drop a plug to upgrade in the end too.
claude-images-mcp.md
Outdated
# Create Images with Claude and Hugging Face | ||
|
||
> [!TIP] | ||
> **TL;DR:** Its easier than ever to generate detailed pictures using the latest AI models - by connecting Claude to Hugging Face Spaces. This article describes how, why, and introduces recently launched models which excel at producing natural images and including text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link some example text to image spaces here?
and perhaps we can emphasise that these models are SoTA.
essentially clause is SoTA for text/ code and these models are SoTA for Image* - combined we make a beast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🔥
Agree, and suggested the same in my review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment, other than that looks great :)
thanks for iterating!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a cursory look - looks good to me.
Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.
Preparing the Article
You're not quite done yet, though. Please make sure to follow this process (as documented here):
md
file. You can also specifyguest
ororg
for the authors.Here is an example of a complete PR: #2382
Getting a Review
Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.
Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.