Skip to content

Commit ab56dfe

Browse files
authored
Update CI (#3194)
* Update CI * I have no clue what was going on with this maturin file, but I don't like it * update cuda container options * Add compute cap to cuda wf * Fix rust toolchain call * update cuda ci runner and bindgen_cuda
1 parent 8ebfc22 commit ab56dfe

File tree

8 files changed

+39
-68
lines changed

8 files changed

+39
-68
lines changed

.github/workflows/ci_cuda.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@ jobs:
1010
group: ${{ github.workflow }}-${{ github.job }}-${{ github.head_ref || github.run_id }}
1111
cancel-in-progress: true
1212
runs-on:
13-
group: aws-g4dn-2xlarge
13+
group: aws-g5-4xlarge-cache
1414
container:
15-
image: nvidia/cuda:12.3.1-devel-ubuntu22.04
16-
options: --gpus 0
15+
image: nvidia/cuda:13.0.2-cudnn-devel-ubuntu24.04
1716
if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}
1817
permissions:
1918
contents: write
@@ -22,13 +21,15 @@ jobs:
2221
# with sigstore/fulcio when running outside of PRs.
2322
id-token: write
2423
security-events: write
24+
env:
25+
CUDA_COMPUTE_CAP: 86
2526
steps:
2627
- name: Checkout repository
27-
uses: actions/checkout@v3
28+
uses: actions/checkout@v5
2829
- name: Install dependencies
29-
run: apt-get update && apt install curl build-essential libssl-dev protobuf-compiler pkg-config -y
30+
run: apt update && apt install curl build-essential libssl-dev protobuf-compiler pkg-config -y
3031
- name: Install Rust Stable
31-
uses: actions-rust-lang/setup-rust-toolchain@v1
32+
uses: dtolnay/rust-toolchain@stable
3233
- uses: Swatinem/rust-cache@v2
3334
- name: Test (cuda)
3435
run: cargo test --features cuda

.github/workflows/maturin.yml

-3.47 KB
Binary file not shown.

.github/workflows/python.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,15 @@ jobs:
2020
os: [ubuntu-latest] # For now, only test on Linux
2121
steps:
2222
- name: Checkout repository
23-
uses: actions/checkout@v4
23+
uses: actions/checkout@v5
2424

2525
- name: Install Rust
26-
uses: actions-rs/toolchain@v1
27-
with:
28-
toolchain: stable
26+
uses: dtolnay/rust-toolchain@stable
2927

3028
- name: Install Python
31-
uses: actions/setup-python@v4
29+
uses: actions/setup-python@v6
3230
with:
33-
python-version: 3.11
31+
python-version: 3.13
3432
architecture: "x64"
3533

3634
- name: Cache Cargo Registry
@@ -42,8 +40,8 @@ jobs:
4240
- name: Install Protoc
4341
uses: arduino/setup-protoc@v2
4442
with:
45-
version: "25.0"
46-
repo-token: ${{ secrets.GITHUB_TOKEN }}
43+
version: "25.0"
44+
repo-token: ${{ secrets.GITHUB_TOKEN }}
4745

4846
- name: Install
4947
working-directory: ./candle-pyo3

.github/workflows/rust-ci.yml

Lines changed: 17 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -13,81 +13,53 @@ jobs:
1313
strategy:
1414
matrix:
1515
os: [ubuntu-latest, windows-latest, macOS-latest]
16-
rust: [stable]
1716
steps:
18-
- uses: actions/checkout@v4
19-
- uses: actions/setup-python@v5
17+
- uses: actions/checkout@v5
18+
- uses: actions/setup-python@v6
2019
with:
21-
python-version: "3.11"
20+
python-version: "3.13"
2221
- name: Remove cargo config (macOS ring crate fix)
2322
if: runner.os == 'macOS'
2423
run: rm -f .cargo/config.toml
25-
- uses: actions-rs/toolchain@v1
26-
with:
27-
profile: minimal
28-
toolchain: ${{ matrix.rust }}
29-
override: true
30-
- uses: actions-rs/cargo@v1
31-
with:
32-
command: check
33-
args: --workspace
24+
- uses: dtolnay/rust-toolchain@stable
25+
- run: cargo check --workspace
3426

3527
test:
3628
name: Test Suite
3729
runs-on: ${{ matrix.os }}
3830
strategy:
3931
matrix:
4032
os: [ubuntu-latest, windows-latest, macOS-latest]
41-
rust: [stable]
4233
steps:
4334
- name: Delete huge unnecessary tools folder
4435
if: runner.os == 'Linux'
4536
run: rm -rf /opt/hostedtoolcache
46-
- uses: actions/checkout@v4
47-
- uses: actions/setup-python@v5
37+
- uses: actions/checkout@v5
38+
- uses: actions/setup-python@v6
4839
with:
49-
python-version: "3.11"
40+
python-version: "3.13"
5041
- name: Remove cargo config (macOS ring crate fix)
5142
if: runner.os == 'macOS'
5243
run: rm -f .cargo/config.toml
53-
- uses: actions-rs/toolchain@v1
54-
with:
55-
profile: minimal
56-
toolchain: ${{ matrix.rust }}
57-
override: true
58-
- uses: actions-rs/cargo@v1
59-
with:
60-
command: test
61-
args: --workspace
44+
- uses: dtolnay/rust-toolchain@stable
45+
- run: cargo test --workspace
6246

6347
fmt:
6448
name: Rustfmt
6549
runs-on: ubuntu-latest
6650
steps:
67-
- uses: actions/checkout@v4
68-
- uses: actions-rs/toolchain@v1
51+
- uses: actions/checkout@v5
52+
- uses: dtolnay/rust-toolchain@stable
6953
with:
70-
profile: minimal
71-
toolchain: stable
72-
override: true
73-
- run: rustup component add rustfmt
74-
- uses: actions-rs/cargo@v1
75-
with:
76-
command: fmt
77-
args: --all -- --check
54+
components: rustfmt
55+
- run: cargo fmt --all -- --check
7856

7957
clippy:
8058
name: Clippy
8159
runs-on: ubuntu-latest
8260
steps:
8361
- uses: actions/checkout@v4
84-
- uses: actions-rs/toolchain@v1
85-
with:
86-
profile: minimal
87-
toolchain: stable
88-
override: true
89-
- run: rustup component add clippy
90-
- uses: actions-rs/cargo@v1
62+
- uses: dtolnay/rust-toolchain@stable
9163
with:
92-
command: clippy
93-
args: --workspace --tests --examples --benches -- -D warnings
64+
components: clippy
65+
- run: cargo clippy --workspace --tests --examples --benches -- -D warnings

.github/workflows/trufflehog.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ jobs:
77
trufflehog:
88
runs-on: ubuntu-latest
99
steps:
10-
- name: Checkout code
11-
uses: actions/checkout@v4
12-
with:
13-
fetch-depth: 0
14-
- name: Secret Scanning
15-
uses: trufflesecurity/trufflehog@main
10+
- name: Checkout code
11+
uses: actions/checkout@v5
12+
with:
13+
fetch-depth: 0
14+
- name: Secret Scanning
15+
uses: trufflesecurity/trufflehog@main

candle-examples/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ tokio = "1.48.0"
5858

5959
[build-dependencies]
6060
anyhow = { workspace = true }
61-
bindgen_cuda = { version = "0.1.1", optional = true }
61+
bindgen_cuda = { version = "0.1.5", optional = true }
6262
hf-hub = { workspace = true, features = ["tokio"] }
6363

6464
[features]

candle-flash-attn/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ candle = { path = "../candle-core", features = ["cuda"], package = "candle-core"
1515
half = { version = "2.3.1", features = ["num-traits"] }
1616

1717
[build-dependencies]
18-
bindgen_cuda = "0.1.1"
18+
bindgen_cuda = "0.1.5"
1919
anyhow = { version = "1", features = ["backtrace"] }
2020

2121
[dev-dependencies]

candle-kernels/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ license = "MIT OR Apache-2.0"
1212
[dependencies]
1313

1414
[build-dependencies]
15-
bindgen_cuda = "0.1.1"
15+
bindgen_cuda = "0.1.5"

0 commit comments

Comments
 (0)