Skip to content

Commit 70b90f4

Browse files
authored
fix: 🐛 ensure all the workers have the same access to the disk (#811)
1 parent 760538a commit 70b90f4

File tree

7 files changed

+16
-1
lines changed

7 files changed

+16
-1
lines changed

chart/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ type: application
1818
# This is the chart version. This version number should be incremented each time you make changes
1919
# to the chart and its templates, including the app version.
2020
# Versions are expected to follow Semantic Versioning (https://semver.org/)
21-
version: 1.1.0
21+
version: 1.1.1
2222

2323
# This is the version number of the application being deployed. This version number should be
2424
# incremented each time you make changes to the application. Versions are not expected to

chart/templates/worker/dataset-info/_container.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
{{ include "envQueue" . | nindent 2 }}
1414
{{ include "envCommon" . | nindent 2 }}
1515
{{ include "envWorker" . | nindent 2 }}
16+
{{ include "envDatasetsBased" . | nindent 2 }}
17+
- name: DATASETS_BASED_HF_DATASETS_CACHE
18+
value: {{ printf "%s/datasets-info/datasets" .Values.cacheDirectory | quote }}
1619
- name: QUEUE_MAX_JOBS_PER_NAMESPACE
1720
# value: {{ .Values.queue.maxJobsPerNamespace | quote }}
1821
# overridden
1922
value: {{ .Values.datasetInfo.queue.maxJobsPerNamespace | quote }}
2023
volumeMounts:
2124
{{ include "volumeMountAssetsRW" . | nindent 2 }}
25+
{{ include "volumeMountCache" . | nindent 2 }}
2226
securityContext:
2327
allowPrivilegeEscalation: false
2428
resources: {{ toYaml .Values.datasetInfo.resources | nindent 4 }}

chart/templates/worker/dataset-info/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ spec:
2222
{{- include "image.imagePullSecrets" . | nindent 6 }}
2323
initContainers:
2424
{{ include "initContainerAssets" . | nindent 8 }}
25+
{{ include "initContainerCache" . | nindent 8 }}
2526
containers: {{ include "containerWorkerDatasetInfo" . | nindent 8 }}
2627
nodeSelector: {{ toYaml .Values.datasetInfo.nodeSelector | nindent 8 }}
2728
tolerations: {{ toYaml .Values.datasetInfo.tolerations | nindent 8 }}

chart/templates/worker/parquet/_container.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
{{ include "envQueue" . | nindent 2 }}
1414
{{ include "envCommon" . | nindent 2 }}
1515
{{ include "envWorker" . | nindent 2 }}
16+
{{ include "envDatasetsBased" . | nindent 2 }}
17+
- name: DATASETS_BASED_HF_DATASETS_CACHE
18+
value: {{ printf "%s/parquet/datasets" .Values.cacheDirectory | quote }}
1619
- name: QUEUE_MAX_JOBS_PER_NAMESPACE
1720
# value: {{ .Values.queue.maxJobsPerNamespace | quote }}
1821
# overridden
1922
value: {{ .Values.parquet.queue.maxJobsPerNamespace | quote }}
2023
volumeMounts:
2124
{{ include "volumeMountAssetsRW" . | nindent 2 }}
25+
{{ include "volumeMountCache" . | nindent 2 }}
2226
securityContext:
2327
allowPrivilegeEscalation: false
2428
resources: {{ toYaml .Values.parquet.resources | nindent 4 }}

chart/templates/worker/parquet/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ spec:
2222
{{- include "image.imagePullSecrets" . | nindent 6 }}
2323
initContainers:
2424
{{ include "initContainerAssets" . | nindent 8 }}
25+
{{ include "initContainerCache" . | nindent 8 }}
2526
containers: {{ include "containerWorkerParquet" . | nindent 8 }}
2627
nodeSelector: {{ toYaml .Values.parquet.nodeSelector | nindent 8 }}
2728
tolerations: {{ toYaml .Values.parquet.tolerations | nindent 8 }}

chart/templates/worker/sizes/_container.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
{{ include "envQueue" . | nindent 2 }}
1414
{{ include "envCommon" . | nindent 2 }}
1515
{{ include "envWorker" . | nindent 2 }}
16+
{{ include "envDatasetsBased" . | nindent 2 }}
17+
- name: DATASETS_BASED_HF_DATASETS_CACHE
18+
value: {{ printf "%s/sizes/datasets" .Values.cacheDirectory | quote }}
1619
- name: QUEUE_MAX_JOBS_PER_NAMESPACE
1720
# value: {{ .Values.queue.maxJobsPerNamespace | quote }}
1821
# overridden
1922
value: {{ .Values.sizes.queue.maxJobsPerNamespace | quote }}
2023
volumeMounts:
2124
{{ include "volumeMountAssetsRW" . | nindent 2 }}
25+
{{ include "volumeMountCache" . | nindent 2 }}
2226
securityContext:
2327
allowPrivilegeEscalation: false
2428
resources: {{ toYaml .Values.sizes.resources | nindent 4 }}

chart/templates/worker/sizes/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ spec:
2222
{{- include "image.imagePullSecrets" . | nindent 6 }}
2323
initContainers:
2424
{{ include "initContainerAssets" . | nindent 8 }}
25+
{{ include "initContainerCache" . | nindent 8 }}
2526
containers: {{ include "containerWorkerSizes" . | nindent 8 }}
2627
nodeSelector: {{ toYaml .Values.sizes.nodeSelector | nindent 8 }}
2728
tolerations: {{ toYaml .Values.sizes.tolerations | nindent 8 }}

0 commit comments

Comments
 (0)