Skip to content

Commit 5de2191

Browse files
committed
ci: pin arrow=21.0.0 since it is released now; restore CI workarounds
1 parent 00a8c54 commit 5de2191

File tree

3 files changed

+14
-34
lines changed

3 files changed

+14
-34
lines changed

.github/workflows/build_documentation.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ jobs:
1515
commit_sha: ${{ github.sha }}
1616
package: datasets
1717
notebook_folder: datasets_doc
18-
additional_args: --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
1918
secrets:
2019
token: ${{ secrets.HUGGINGFACE_PUSH }}
2120
hf_token: ${{ secrets.HF_DOC_BUILD_PUSH }}

.github/workflows/ci.yml

Lines changed: 12 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ on:
55
branches:
66
- main
77
push:
8-
# branches:
9-
# - main
10-
# - ci-*
8+
branches:
9+
- main
10+
- ci-*
1111

1212
env:
13-
CI_HEADERS: ${{ secrets.CI_HEADERS }}
13+
HF_ALLOW_CODE_EVAL: 1
1414

1515
jobs:
1616

@@ -25,7 +25,6 @@ jobs:
2525
- name: Install dependencies
2626
run: |
2727
python -m pip install --upgrade pip
28-
pip install --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple "pyarrow>=21.0.0.dev"
2928
pip install .[quality]
3029
- name: Check quality
3130
run: |
@@ -45,29 +44,25 @@ jobs:
4544
- uses: actions/checkout@v4
4645
with:
4746
fetch-depth: 0
48-
- name: Setup FFmpeg
49-
if: ${{ matrix.os == 'ubuntu-latest' }}
50-
run: |
51-
sudo apt update
52-
sudo apt install -y ffmpeg
5347
- name: Set up Python 3.9
5448
uses: actions/setup-python@v5
5549
with:
5650
python-version: "3.9"
5751
- name: Upgrade pip
5852
run: python -m pip install --upgrade pip
53+
- name: Pin setuptools-scm
54+
if: ${{ matrix.os == 'ubuntu-latest' }}
55+
run: echo "installing pinned version of setuptools-scm to fix seqeval installation on 3.7" && pip install "setuptools-scm==6.4.2"
5956
- name: Install uv
6057
run: pip install --upgrade uv
6158
- name: Install dependencies
62-
run: |
63-
uv pip install --system --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple "pyarrow>=21.0.0.dev"
64-
uv pip install --system "datasets[tests] @ ."
59+
run: uv pip install --system "datasets[tests] @ ."
6560
- name: Install dependencies (latest versions)
6661
if: ${{ matrix.deps_versions == 'deps-latest' }}
67-
run: uv pip install --system --upgrade huggingface-hub "dill<0.3.9"
62+
run: uv pip install --system --upgrade pyarrow huggingface-hub "dill<0.3.9"
6863
- name: Install dependencies (minimum versions)
6964
if: ${{ matrix.deps_versions != 'deps-latest' }}
70-
run: uv pip install --system huggingface-hub==0.24.7 transformers dill==0.3.1.1
65+
run: uv pip install --system pyarrow==15.0.0 huggingface-hub==0.24.7 transformers dill==0.3.1.1
7166
- name: Test with pytest
7267
run: |
7368
python -m pytest -rfExX -m ${{ matrix.test }} -n 2 --dist loadfile -sv ./tests/
@@ -85,11 +80,6 @@ jobs:
8580
- uses: actions/checkout@v4
8681
with:
8782
fetch-depth: 0
88-
- name: Setup FFmpeg
89-
if: ${{ matrix.os == 'ubuntu-latest' }}
90-
run: |
91-
sudo apt update
92-
sudo apt install -y ffmpeg
9383
- name: Set up Python 3.11
9484
uses: actions/setup-python@v5
9585
with:
@@ -99,9 +89,7 @@ jobs:
9989
- name: Install uv
10090
run: pip install --upgrade uv
10191
- name: Install dependencies
102-
run: |
103-
uv pip install --system --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple "pyarrow>=21.0.0.dev"
104-
uv pip install --system "datasets[tests] @ ."
92+
run: uv pip install --system "datasets[tests] @ ."
10593
- name: Test with pytest
10694
run: |
10795
python -m pytest -rfExX -m ${{ matrix.test }} -n 2 --dist loadfile -sv ./tests/
@@ -119,11 +107,6 @@ jobs:
119107
- uses: actions/checkout@v4
120108
with:
121109
fetch-depth: 0
122-
- name: Setup FFmpeg
123-
if: ${{ matrix.os == 'ubuntu-latest' }}
124-
run: |
125-
sudo apt update
126-
sudo apt install -y ffmpeg
127110
- name: Set up Python 3.11
128111
uses: actions/setup-python@v5
129112
with:
@@ -133,9 +116,7 @@ jobs:
133116
- name: Install uv
134117
run: pip install --upgrade uv
135118
- name: Install dependencies
136-
run: |
137-
uv pip install --system --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple "pyarrow>=21.0.0.dev"
138-
uv pip install --system "datasets[tests_numpy2] @ ."
119+
run: uv pip install --system "datasets[tests_numpy2] @ ."
139120
- name: Test with pytest
140121
run: |
141122
python -m pytest -rfExX -m ${{ matrix.test }} -n 2 --dist loadfile -sv ./tests/

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@
110110
# We use numpy>=1.17 to have np.random.Generator (Dataset shuffling)
111111
"numpy>=1.17",
112112
# Backend and serialization.
113-
# Minimum 15.0.0 to be able to cast dictionary types to their underlying types
114-
"pyarrow>=21.0.0.dev",
113+
# Minimum 21.0.0 to support `use_content_defined_chunking` in ParquetWriter
114+
"pyarrow>=21.0.0",
115115
# For smart caching dataset processing
116116
"dill>=0.3.0,<0.3.9", # tmp pin until dill has official support for determinism see https://github.com/uqfoundation/dill/issues/19
117117
# For performance gains with apache arrow

0 commit comments

Comments
 (0)