Skip to content

Commit 28ff59d

Browse files
Apply suggestions from code review
Co-authored-by: Linoy Tsaban <[email protected]>
1 parent c504c27 commit 28ff59d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

examples/dreambooth/README_flux.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,8 +319,9 @@ accelerate launch train_dreambooth_lora_flux_kontext.py \
319319
--cache_latents \
320320
--learning_rate=1e-4 \
321321
--lr_scheduler="constant" \
322-
--lr_warmup_steps=0 \
323-
--max_train_steps=500 \
322+
--lr_warmup_steps=200 \
323+
--max_train_steps=1000 \
324+
--rank=16\
324325
--seed="0"
325326
```
326327

examples/dreambooth/train_dreambooth_lora_flux_kontext.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,8 @@ def __init__(
795795
column_names = dataset["train"].column_names
796796

797797
# 6. Get the column names for input/target.
798-
# TODO: add validation for `cond_image_column`
798+
if args.cond_image_column is not None and not args.cond_image_column in column_names:
799+
raise ValueError(f"`--cond_image_column` value '{args.cond_image_column}' not found in dataset columns. Dataset columns are: {', '.join(column_names)}")
799800
if args.image_column is None:
800801
image_column = column_names[0]
801802
logger.info(f"image column defaulting to {image_column}")

0 commit comments

Comments
 (0)